Add support to save chat panel's scroll position#88
Merged
anguyen-yext2 merged 6 commits intomainfrom Jan 8, 2025
Merged
Conversation
J=CLIP-1675 TEST=manual,auto verified on test-site that the panel remains at the correct scroll position after being reloaded/opened in another tab. Also verified that multiple bot panels do not override each other scroll position. added and ran unit test
nbramblett
reviewed
Dec 26, 2024
nbramblett
approved these changes
Jan 2, 2025
yen-tt
reviewed
Jan 2, 2025
yen-tt
reviewed
Jan 2, 2025
yen-tt
reviewed
Jan 2, 2025
yen-tt
reviewed
Jan 6, 2025
yen-tt
approved these changes
Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
J=CLIP-1675
TEST=manual,auto
verified on test-site that the panel remains at the correct scroll position after being reloaded/opened in another tab. Also verified that multiple bot panels do not override each other scroll position.
added and ran unit test
https://github.com/user-attachments/assets/d3ade9aa-02e0-445b-b32d-ca1926bf5d4b