Patch input to handle Enter event for japanese keyboards correctly#71
Merged
nbramblett merged 1 commit intomainfrom May 16, 2024
Merged
Patch input to handle Enter event for japanese keyboards correctly#71nbramblett merged 1 commit intomainfrom
nbramblett merged 1 commit intomainfrom
Conversation
yen-tt
approved these changes
May 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a clear summary of the issue and the solution, see below:
https://dninomiya.github.io/form-guide/stop-enter-submit
Tested via our dev page using the japanese keyboard - I hit enter and verified that it converted the characters but did not send a message. Subsequently hitting Enter correctly sent the message.
I also double-checked that other keyboards (english) still only require one press of the Enter key, so this should be a completely invisible change to anyone using other languages.