ChatPanel: add onLinkClick handler for footer#65
Merged
anguyen-yext2 merged 4 commits intomainfrom Feb 14, 2024
Merged
Conversation
J=CLIP-432 TEST=auto,manual tested manually on test site by passing a print statement to the handler and verified that the link is printed when it's clicked. added auto test and ran `npm run test`.
yen-tt
reviewed
Feb 13, 2024
Collaborator
yen-tt
left a comment
yen-tt
left a comment
There was a problem hiding this comment.
make sure to resolve errors from the GH lint action (missing deps in useMemo)
yen-tt
reviewed
Feb 13, 2024
Collaborator
yen-tt
left a comment
yen-tt
left a comment
There was a problem hiding this comment.
nice! You should probably bump the package version to deploy this change after it's merged. make sure to run npm run build after the change.
yen-tt
approved these changes
Feb 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
J=CLIP-432
TEST=auto,manual
tested manually on test site by passing a print statement to the handler and verified that the link is printed when it's clicked. added auto test and ran
npm run test.