Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include full entity data in GDA citations #1923

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

k-gerner
Copy link
Contributor

@k-gerner k-gerner commented Mar 5, 2025

In this change we have the following changes:

  • Pass raw data from entity result to GDA component (this will allow customization of what data is shown or used in the GDA component)
  • No longer include links on the citations in the default GDA template. This should not be an issue as no one should be using the default template from this repo
    J=WAT-4680

@k-gerner k-gerner requested a review from a team as a code owner March 5, 2025 21:32
@coveralls
Copy link

Coverage Status

coverage: 61.782%. remained the same
when pulling 09640fe on dev/gda-include-full-entity-data-in-citations
into 2ae5869 on develop.

Copy link
Contributor

@Fondryext Fondryext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remind me, we're removing the link because not all results will have the relevant link as the .link field?

@k-gerner
Copy link
Contributor Author

k-gerner commented Mar 6, 2025

Remind me, we're removing the link because not all results will have the relevant link as the .link field?

Yes, and the link field is not used in the theme anymore, so it's only purpose would be for this default answers-search-ui version of the component, which should never get used anyways.

@k-gerner k-gerner merged commit 0d7c308 into develop Mar 6, 2025
11 of 14 checks passed
@k-gerner k-gerner deleted the dev/gda-include-full-entity-data-in-citations branch March 6, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants