Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files uploading support #464

Merged
merged 1 commit into from
Feb 16, 2019
Merged

Add files uploading support #464

merged 1 commit into from
Feb 16, 2019

Conversation

therustmonk
Copy link
Member

@therustmonk therustmonk commented Feb 10, 2019

New feature: files uploading.

  1. New variant of ChangeData::Files of onchange handler.
  2. New ReaderService to read File instances.
  3. New file_upload example that prints sizes of uploaded files.

Can't be merged now because of: koute/stdweb#323

@koute
Copy link
Contributor

koute commented Feb 13, 2019

@deniskolodin stdweb 0.4.14 was just released on crates.io so you should be able to proceed with this. (:

@therustmonk
Copy link
Member Author

@koute Thank you so much for the release! To be honest I really need it, but hesitated to ask )

@koute
Copy link
Contributor

koute commented Feb 13, 2019

@deniskolodin My pleasure. (: If you need something in the future please do not hesitate to ask - I'm always happy to help, even if I might be temporarily occupied with something else! (:

@therustmonk
Copy link
Member Author

@koute Thank you! 👌

@therustmonk
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Feb 16, 2019
464: Add files uploading support r=DenisKolodin a=DenisKolodin

New feature: **files uploading**.

1. New variant of `ChangeData::Files` of `onchange` handler.
2. New `ReaderService` to read `File` instances.
3. New `file_upload` example that prints sizes of uploaded files.

Can't be merged now because of: koute/stdweb#323

Co-authored-by: Denis Kolodin <deniskolodin@gmail.com>
@bors
Copy link
Contributor

bors bot commented Feb 16, 2019

Build succeeded

@bors bors bot merged commit 654716f into master Feb 16, 2019
@therustmonk therustmonk deleted the file-upload branch February 19, 2019 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants