-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Remove class=(...)
syntax
#3497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove class=(...)
syntax
#3497
Conversation
Visit the preview URL for this PR (updated for commit 3d983e5): https://yew-rs-api--pr3497-remove-old-class-syn-fk69c597.web.app (expires Sat, 04 Nov 2023 13:20:53 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Benchmark - SSRYew Master
Pull Request
|
Size Comparison
✅ None of the examples has changed their size significantly. |
Benchmark - coreYew Master
Pull Request
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
* removed class=(...) syntax * made DynamicName::expr a group instead of a block * fixed tests, silenced all unused_must_use warnings * fixed wasm test
Description
Fixes #3478 and changes
DynamicName::expr
's type to not redundantly parse the expression in the brackets and to not trigger anunused_braces
warning with the generated codeChecklist