-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep checked attribute for elements without special handling #3373
Conversation
Visit the preview URL for this PR (updated for commit 50590ea): https://yew-rs-api--pr3373-keep-checked-ssq9ptrv.web.app (expires Wed, 16 Aug 2023 20:33:49 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Size Comparison
✅ None of the examples has changed their size significantly. |
Benchmark - SSRYew Master
Pull Request
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am approving this pull request as I do not think the CI failures are related.
Description
Input and textarea elements are handled specially.
html!
macro popped checked attribute for every element but did not return it if the element was one without special handling. This PR fixes thatFixes #3189
Checklist