Fix Dependabot and GitHub Actions#3111
Merged
Merged
Conversation
Size ComparisonDetails
|
|
Visit the preview URL for this PR (updated for commit ba3ccf5): https://yew-rs--pr3111-fix-dependabot-odb3lfnp.web.app (expires Sat, 11 Mar 2023 17:41:24 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Benchmark - SSRYew MasterDetails
Pull RequestDetails
|
# Conflicts: # .github/workflows/main-checks.yml # .github/workflows/tools-examples.yml
ranile
approved these changes
Mar 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Dependabot currently does not work most of the time due to it cannot recognise certain tags for GitHub Actions and cargo local dependencies.
This pull request aims to address this.
This pull request:
This fixes:
1. Dependabot (Dependabot does not work for examples and tools because they references crates outside of their workspace.)
2. Rust Analyzer (because examples and tools are not in workspace, Rust Analyzer is not run unless workspace is switched to examples or tools.)
website/orpackages/is modified. (See: Update events.mdx #3052 (review))Cargo.lockis checked in. This ensures examples and tools will always properly build.Cargo.lock is ignored when publishing library crates.
oleksiyrudenko/gha-git-credentials. This hopefully fixes Dependabot for GitHub Actions.browser-actions/setup-geckodriverso it does not exceed limit.To mitigate #2744,
I have included a crate that uses a higher than MSRV to make sure things are still working after merging.
This pull request also includes #3110, #3110 should be merged first.
Checklist