Skip to content

Fix Dependabot and GitHub Actions#3111

Merged
futursolo merged 14 commits into
yewstack:masterfrom
futursolo:fix-dependabot
Mar 4, 2023
Merged

Fix Dependabot and GitHub Actions#3111
futursolo merged 14 commits into
yewstack:masterfrom
futursolo:fix-dependabot

Conversation

@futursolo
Copy link
Copy Markdown
Member

@futursolo futursolo commented Feb 2, 2023

Description

Dependabot currently does not work most of the time due to it cannot recognise certain tags for GitHub Actions and cargo local dependencies.
This pull request aims to address this.

This pull request:

  1. Merges workspace
    This fixes:
    1. Dependabot (Dependabot does not work for examples and tools because they references crates outside of their workspace.)
    2. Rust Analyzer (because examples and tools are not in workspace, Rust Analyzer is not run unless workspace is switched to examples or tools.)
  2. Run website snippet tests on when either website/ or packages/ is modified. (See: Update events.mdx #3052 (review))
  3. Cargo.lock is checked in. This ensures examples and tools will always properly build.
    Cargo.lock is ignored when publishing library crates.
  4. Use a version for oleksiyrudenko/gha-git-credentials. This hopefully fixes Dependabot for GitHub Actions.
  5. Run clippy once for the entire workspace.
  6. Run rustfmt once for the entire workspace.
  7. Provide GitHub Actions token to browser-actions/setup-geckodriver so it does not exceed limit.
  8. Updates dependencies for examples and tools.

To mitigate #2744,
I have included a crate that uses a higher than MSRV to make sure things are still working after merging.

This pull request also includes #3110, #3110 should be merged first.

Checklist

  • I have reviewed my own code
  • I have added tests

github-actions[bot]
github-actions Bot previously approved these changes Feb 2, 2023
github-actions[bot]
github-actions Bot previously approved these changes Feb 2, 2023
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 2, 2023

Size Comparison

Details
examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock 107.839 99.804 -8.035 -7.451%
boids 170.485 170.603 +0.117 +0.069%
communication_child_to_parent 90.817 90.872 +0.055 +0.060%
communication_grandchild_with_grandparent 104.768 104.818 +0.051 +0.048%
communication_grandparent_to_grandchild 100.691 100.749 +0.058 +0.057%
communication_parent_to_child 87.956 88.008 +0.052 +0.059%
contexts 107.178 107.232 +0.055 +0.051%
counter 85.766 85.825 +0.060 +0.069%
counter_functional 86.067 86.118 +0.051 +0.059%
dyn_create_destroy_apps 88.591 88.695 +0.104 +0.118%
file_upload 100.299 100.357 +0.059 +0.058%
function_memory_game 163.976 164.097 +0.121 +0.074%
function_router 346.624 346.602 -0.022 -0.006%
function_todomvc 159.302 159.387 +0.085 +0.053%
futures 223.952 224.081 +0.129 +0.058%
game_of_life 106.512 106.648 +0.137 +0.128%
immutable 180.896 180.744 -0.152 -0.084%
inner_html 82.196 82.248 +0.052 +0.063%
js_callback 111.572 111.635 +0.062 +0.056%
keyed_list 196.518 196.589 +0.071 +0.036%
mount_point 85.396 85.449 +0.053 +0.062%
nested_list 112.965 113.017 +0.052 +0.046%
node_refs 93.411 93.470 +0.059 +0.063%
password_strength 1548.765 1550.238 +1.474 +0.095%
portals 96.545 96.604 +0.059 +0.061%
router 317.915 317.909 -0.006 -0.002%
simple_ssr 150.803 150.851 +0.048 +0.032%
ssr_router 393.076 393.036 -0.040 -0.010%
suspense 108.720 108.878 +0.158 +0.146%
timer 88.668 88.761 +0.093 +0.105%
todomvc 141.062 141.150 +0.088 +0.062%
two_apps 86.391 86.441 +0.051 +0.059%
web_worker_fib 151.931 152.081 +0.150 +0.099%
webgl 84.976 85.030 +0.055 +0.064%

⚠️ The following example has changed its size significantly:

examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock 107.839 99.804 -8.035 -7.451%

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 2, 2023

Visit the preview URL for this PR (updated for commit ba3ccf5):

https://yew-rs--pr3111-fix-dependabot-odb3lfnp.web.app

(expires Sat, 11 Mar 2023 17:41:24 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

github-actions[bot]
github-actions Bot previously approved these changes Feb 2, 2023
github-actions[bot]
github-actions Bot previously approved these changes Feb 2, 2023
github-actions[bot]
github-actions Bot previously approved these changes Feb 2, 2023
github-actions[bot]
github-actions Bot previously approved these changes Feb 2, 2023
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 2, 2023

Benchmark - SSR

Yew Master

Details
Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 371.968 372.620 372.159 0.216
Hello World 10 684.271 698.338 687.320 4.581
Function Router 10 2376.619 2396.883 2388.469 6.848
Concurrent Task 10 1007.343 1009.374 1008.565 0.650

Pull Request

Details
Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 371.722 372.086 371.864 0.122
Hello World 10 671.404 673.913 673.003 0.766
Function Router 10 2273.963 2313.134 2297.740 10.319
Concurrent Task 10 1007.702 1009.061 1008.377 0.435

# Conflicts:
#	.github/workflows/main-checks.yml
#	.github/workflows/tools-examples.yml
@ranile ranile added the A-ci Area: The continuous integration label Mar 4, 2023
@futursolo futursolo merged commit 08f4fd3 into yewstack:master Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ci Area: The continuous integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants