-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Fix dangling urls #2728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dangling urls #2728
Conversation
Thanks for the PR 👍 If gloo doesn't self-host the docs anymore, I'd rather these links point to the docs.rs pages, i.e. https://docs.rs/gloo-console/*/gloo_console/struct.Timer.html and https://docs.rs/gloo-timers/ instead of their implementation. |
Size Comparison
✅ None of the examples has changed their size significantly. |
I fixed all dangling urls from https://gloo-rs.web.app/docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my side. Unless @hamza1311 has another suggestion for the URL, linking to docs.rs seems like the best course of action.
docs.rs is the best way to link to gloo docs. The website is simply is an introduction to what Gloo is and how to get started |
No description provided.