Skip to content

Fix dangling urls #2728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2022
Merged

Fix dangling urls #2728

merged 1 commit into from
Jun 19, 2022

Conversation

sephiron99
Copy link
Contributor

No description provided.

@WorldSEnder
Copy link
Member

WorldSEnder commented Jun 11, 2022

Thanks for the PR 👍

If gloo doesn't self-host the docs anymore, I'd rather these links point to the docs.rs pages, i.e. https://docs.rs/gloo-console/*/gloo_console/struct.Timer.html and https://docs.rs/gloo-timers/ instead of their implementation.

@WorldSEnder WorldSEnder added the A-examples Area: The examples label Jun 11, 2022
@github-actions
Copy link

github-actions bot commented Jun 11, 2022

Size Comparison

examples master (KB) pull request (KB) diff (KB) diff (%)
boids 172.976 172.976 0 0.000%
contexts 109.756 109.756 0 0.000%
counter 86.720 86.720 0 0.000%
counter_functional 87.375 87.375 0 0.000%
dyn_create_destroy_apps 89.861 89.861 0 0.000%
file_upload 102.797 102.797 0 0.000%
function_memory_game 167.422 167.422 0 0.000%
function_router 350.100 350.100 0 0.000%
function_todomvc 162.066 162.066 0 0.000%
futures 227.086 227.086 0 0.000%
game_of_life 107.706 107.706 0 0.000%
inner_html 83.790 83.790 0 0.000%
js_callback 112.969 112.969 0 0.000%
keyed_list 195.259 195.259 0 0.000%
mount_point 86.349 86.349 0 0.000%
nested_list 116.092 116.092 0 0.000%
node_refs 93.774 93.774 0 0.000%
password_strength 1538.631 1538.631 0 0.000%
portals 97.359 97.359 0 0.000%
router 319.046 319.046 0 0.000%
simple_ssr 153.690 153.690 0 0.000%
ssr_router 395.627 395.627 0 0.000%
suspense 110.665 110.665 0 0.000%
timer 89.460 89.460 0 0.000%
todomvc 143.130 143.130 0 0.000%
two_apps 87.331 87.331 0 0.000%
web_worker_fib 153.789 153.789 0 0.000%
webgl 87.608 87.608 0 0.000%

✅ None of the examples has changed their size significantly.

@WorldSEnder WorldSEnder requested a review from ranile June 12, 2022 13:33
@sephiron99 sephiron99 closed this Jun 12, 2022
@sephiron99 sephiron99 reopened this Jun 12, 2022
@sephiron99
Copy link
Contributor Author

I fixed all dangling urls from https://gloo-rs.web.app/docs

Copy link
Member

@WorldSEnder WorldSEnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side. Unless @hamza1311 has another suggestion for the URL, linking to docs.rs seems like the best course of action.

@ranile
Copy link
Member

ranile commented Jun 19, 2022

Looks good from my side. Unless @hamza1311 has another suggestion for the URL, linking to docs.rs seems like the best course of action.

docs.rs is the best way to link to gloo docs. The website is simply is an introduction to what Gloo is and how to get started

@ranile ranile merged commit 0bdbd95 into yewstack:master Jun 19, 2022
@sephiron99 sephiron99 deleted the patch-1 branch June 25, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-examples Area: The examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants