Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement From<Cow<'static, str>> for AttrValue #2200

Merged
merged 3 commits into from
Nov 26, 2021
Merged

implement From<Cow<'static, str>> for AttrValue #2200

merged 3 commits into from
Nov 26, 2021

Conversation

Madoshakalaka
Copy link
Member

Description

Fixes #2198

Checklist

  • I have run cargo make pr-flow
  • I've linted code.
  • I have reviewed my own code
  • I have added tests

ranile
ranile previously approved these changes Nov 26, 2021
View reviewed changes
@ranile ranile requested a review from voidpumpkin November 26, 2021 04:58
@Madoshakalaka Madoshakalaka requested a review from ranile November 26, 2021 05:00
voidpumpkin
voidpumpkin approved these changes Nov 26, 2021
View reviewed changes
Copy link
Member

@voidpumpkin voidpumpkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@voidpumpkin voidpumpkin merged commit 83aa051 into yewstack:master Nov 26, 2021
@voidpumpkin voidpumpkin mentioned this pull request Nov 26, 2021
Merged
3 tasks
@Madoshakalaka Madoshakalaka deleted the attr_val_from_cow_static branch November 30, 2021 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@voidpumpkin voidpumpkin voidpumpkin approved these changes

@ranile ranile ranile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

the trait From<Cow<'_, str>> is not implemented for AttrValue
3 participants
@Madoshakalaka @voidpumpkin @ranile