-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Move top-level crates to packages/<crate> #1680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move top-level crates to packages/<crate> #1680
Conversation
Visit the preview URL for this PR (updated for commit 2fe8166): https://yew-rs--pr1680-peterson-packages-le-hvnvrwad.web.app (expires Tue, 19 Jan 2021 03:22:02 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Seeing a strange CI failure.
|
I think that the examples should be kept at root so any newcomer who doesn't know the directory structure doesn't assume that there aren't any examples without looking under the packages directory. I feel like it isn't right to expect newcomers to look in a subdirectory to find the examples directory. |
Thanks for taking this on @philip-peterson, happy to merge when CI is happy and examples get moved back to root like @hamza1311 has suggested |
Can you also rebase to pick up the fix in #1683? |
c8a56ea
to
349f56f
Compare
Rebased and adjusted, PR is now failing on some integration tests I'm not sure how to fix. |
Thanks for your thoroughness! |
@jstarry Happy to be of help! |
Description
This moves all top-level crates to a directory called packages and updates relevant documentation.
Fixes #1669
Checklist
cargo make pr-flow