Skip to content

Move top-level crates to packages/<crate> #1680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 12, 2021

Conversation

philip-peterson
Copy link
Contributor

@philip-peterson philip-peterson commented Jan 7, 2021

Description

This moves all top-level crates to a directory called packages and updates relevant documentation.

Fixes #1669

Checklist

  • I have run cargo make pr-flow
  • I have reviewed my own code
  • I have added tests

@github-actions
Copy link

github-actions bot commented Jan 7, 2021

Visit the preview URL for this PR (updated for commit 2fe8166):

https://yew-rs--pr1680-peterson-packages-le-hvnvrwad.web.app

(expires Tue, 19 Jan 2021 03:22:02 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@philip-peterson
Copy link
Contributor Author

Seeing a strange CI failure.

    Checking yewtil-macro v0.2.0 (/home/runner/work/yew/yew/packages/yewtil-macro)
error[E0432]: unresolved import `syn::export`
Error:  --> packages/yewtil-macro/src/function_component.rs:4:10
  |
4 | use syn::export::ToTokens;
  |          ^^^^^^ could not find `export` in `syn`

@ranile
Copy link
Member

ranile commented Jan 7, 2021

I think that the examples should be kept at root so any newcomer who doesn't know the directory structure doesn't assume that there aren't any examples without looking under the packages directory. I feel like it isn't right to expect newcomers to look in a subdirectory to find the examples directory.

@jstarry
Copy link
Member

jstarry commented Jan 10, 2021

Thanks for taking this on @philip-peterson, happy to merge when CI is happy and examples get moved back to root like @hamza1311 has suggested

@jstarry
Copy link
Member

jstarry commented Jan 10, 2021

Can you also rebase to pick up the fix in #1683?

@philip-peterson philip-peterson force-pushed the peterson/packages-level branch from c8a56ea to 349f56f Compare January 12, 2021 01:06
@philip-peterson
Copy link
Contributor Author

Rebased and adjusted, PR is now failing on some integration tests I'm not sure how to fix.

@jstarry
Copy link
Member

jstarry commented Jan 12, 2021

Thanks for your thoroughness!

@jstarry jstarry merged commit e6a3ae7 into yewstack:master Jan 12, 2021
@philip-peterson
Copy link
Contributor Author

@jstarry Happy to be of help!

@philip-peterson philip-peterson deleted the peterson/packages-level branch January 12, 2021 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move all yew-xxx crates into a packages folder.
3 participants