Correct documentation redirects (and fix the workflow) #1621

siku2 · 2020-10-15T20:05:24Z

Description

See #1619 for what went wrong.

I finally bit the bullet and set up a test Firebase environment again so this time it'll work for sure 🙃

I also remembered that our redirects were kinda broken so I fixed that too.

Fixes #1563

renamed intro.md to index.md. By having an actual index file, most of the redirect problems magically go away. I added a redirect from /intro to / so old links don't break.
removed the redirects which weren't required at all because Docusaurus already builds the file structure with redirects.
removed the rewrite. 404s now actually 404 instead of just redirecting to the intro. This should help avoid confusing situations, especially with other languages (See Modified links for documents #1562)

* trigger change * redirects * update config

siku2 added 13 commits October 15, 2020 01:17

checkout before artifact

c5bdf67

config for fork

ea56ebf

pass pull request number (again)

a5674d3

worthless change to trigger build

bdbfc21

use comment url path

31f3a93

let's play around with redirects

3d2d461

Test (#18)

ca0a33e

* trigger change * redirects * update config

remove firebase.json from pull request

07bc2a6

remove redirects

ce2d99e

use an index page instead of redirects

6f89966

intro -> index

f9d18fe

revert unnecessary changes

c5855ac

correct format

c196732

siku2 added documentation meta Repository chores and tasks labels Oct 15, 2020

siku2 merged commit cbf6a13 into yewstack:master Oct 15, 2020

siku2 deleted the hello-darkness-my-old-friend branch October 15, 2020 20:11