feat(web): buy nft UI #533
Open
+3,698
−690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcosNicolau
changed the base branch from
feat/public-nft-logic
to
feat/separate-discount-whitelist-generation
| select: 1 | ||
| ) | ||
|
|
||
| Logger.info("Checking eligibility for address: #{address} with query: #{inspect(query)}") |
Collaborator
There was a problem hiding this comment.
Suggested change
| Logger.info("Checking eligibility for address: #{address} with query: #{inspect(query)}") |
I think we can remove this log.
| @@ -1,5 +1,6 @@ | |||
| defmodule ZkArcadeWeb.ApiController do | |||
| use ZkArcadeWeb, :controller | |||
| require Logger | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| require Logger |
The module does not use the Logger.
| def buy_nft(conn, _params) do | ||
| wallet = get_wallet_from_session(conn) | ||
| eligible = get_user_eligibility(wallet) | ||
| # To be replaced with whitelist merkle proof |
Collaborator
There was a problem hiding this comment.
Suggested change
| # To be replaced with whitelist merkle proof |
maximopalopoli
approved these changes
Nov 11, 2025
Collaborator
maximopalopoli
left a comment
maximopalopoli
left a comment
There was a problem hiding this comment.
LGTM. Anyway, I think that we should tell the users that the public NFT is not available in the meantime (until we deploy it)
* Separate the data folder into one per nft * remove unnecessary makefile target * Redo the output files to consider the origin whitelist path * Handle and exclusive public merkle proof insert into db * Add the merkle path public schema * Expose user eligibility and proofs for public NFT on backend * fix: use the public nft merkle output path * Rename merklePathsPublic to PublicMerklePaths * update the readme instructions * feat: apply some fixes and improvements * refactor: maxSupply applies for both mints * fix: remove reentrant guard fix: deployer * fix: update config files * remove inserted devnet files * update gitignore * Add inspect to error in batcher connection to avoid formatting panics --------- Co-authored-by: JuArce <52429267+JuArce@users.noreply.github.com> Co-authored-by: Marcos Nicolau <marcosnicolau@lambdaclass.com>
Base automatically changed from
feat/separate-discount-whitelist-generation
to
feat/public-nft-logic
November 12, 2025 17:01
…/second-nft-claim
* feat(web): add support for public nft it is not deployed * add utils function * show correct messages
* apply feedback * Separate the price and discount lines --------- Co-authored-by: maximopalopoli <mpalopoli@fi.uba.ar>
* metrics for public nfts mints * return err to already added token to not increment multiple times * update grafana dashboard json * fix: update grafana dashboard * fix: do not log warning where there is no change on user nfts --------- Co-authored-by: JuArce <52429267+JuArce@users.noreply.github.com>
JuArce
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
/mintif eligible for premium nft/nft/buyif not eligible for premium nft