Skip to content

chore(dev): targets to verify aggregated proof for every network #1943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 4, 2025

Conversation

MarcosNicolau
Copy link
Member

@MarcosNicolau MarcosNicolau commented May 20, 2025

Description

Previously, the target to verify if a proof was aggregated was hardcoded for holesky-stage. Since we now have ethereum-package and holesky, the target was updated to support every network. Also, based on the NETWORK param the RPC_URL and BEACON_URL are automatically set to public nodes.

How to test

  1. Start ethereum package: make ethereum_package_start
  2. Start batcher: make batcher_start_ethereum_package
  3. Send proofs: make batcher_send_sp1_burst && make batcher_send_risc0_burst
  4. Run aggregator: make start_proof_aggregator AGGREGATOR=sp1|risc0
  5. Verify the proofs have been aggregated:
make verify_aggregated_proof_sp1 FROM_BLOCK=0
make verify_aggregated_proof_risc0 FROM_BLOCK=0
  1. You should also test the same command for holesky and holesky-stage
make verify_aggregated_proof_sp1 FROM_BLOCK=<LOOK_IN_EXPLORER> NETWORK=holesky-stage
make verify_aggregated_proof_risc0 FROM_BLOCK=<LOOK_IN_EXPLORER> NETWORK=holesky-stage

Type of change

  • Dev experience

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@MarcosNicolau MarcosNicolau self-assigned this May 20, 2025
@MauroToscano MauroToscano added this pull request to the merge queue Jun 4, 2025
Merged via the queue into staging with commit 3574467 Jun 4, 2025
1 check passed
@MauroToscano MauroToscano deleted the chore/targets-to-verify-agg-proof branch June 4, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants