LRS-70 Pass multipart statement to attachment validation to impl #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing this, in light of #81: if deduplicated attachments are accepted, there is no way to tie a statement attachment reference 1-1 with an attachment without the expectation of denormalization. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LRS-70 We match and validate statement data to attachments, but throw out the resulting pairing.
It would be useful for impls to have this for a variety of reasons, chiefly addressing attachment storage
Also examine current behavior: We require that there be a (possibly duplicate) attachment present for each reference, even if the SHA2 is the same. Figure out if this is intended + correct behavior.