Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MySQL constraint= attribute test #986

Merged
merged 1 commit into from
Nov 7, 2019
Merged

MySQL constraint= attribute test #986

merged 1 commit into from
Nov 7, 2019

Conversation

robbassi
Copy link
Contributor

@robbassi robbassi commented Nov 7, 2019 •
edited
Loading

This PR ports the Postgresql CustomConstraintTest from #979 to the MySQL backend.

Before submitting your PR, check that you've:

  • Bumped the version number

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@robbassi
Copy link
Contributor Author

robbassi commented Nov 7, 2019

@parsonsmatt since this PR only adds a test, would this require a version bump?

@parsonsmatt
Copy link
Collaborator

Nope! Thanks for the test 😄

@parsonsmatt parsonsmatt merged commit d79385d into yesodweb:master Nov 7, 2019
@robbassi robbassi deleted the mysql-custom-constraint-test branch November 7, 2019 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robbassi @parsonsmatt