-
Notifications
You must be signed in to change notification settings - Fork 66
Fix Linux paths to detect installed location #462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
1337joe
wants to merge
978
commits into
yermak:development
from
1337joe:fix-platform-properties-logging
Closed
Fix Linux paths to detect installed location #462
1337joe
wants to merge
978
commits into
yermak:development
from
1337joe:fix-platform-properties-logging
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automatic Linux build, some bug fixes
Add audio speed up / slow down
feature/153_limit_art_works
Rewrite speed variable using ObjectProperty
Audio speed up / slow down. Bug fixes.
…formatting yermak#202 Customise formatting.
Show recalculated (based on speed) duration for the original file and for chapter
Bug fixes and minor improvements
176_light_choco_build
fixed SSL certificate handshake
Jpeg detection bug fixed
Track Tag in m4b and ogg files
Fixed large file size estimate
…le and maintainable
…le and maintainable
…g_mp3 Fixed playing mp3
… split by track, which created race conditions
…error Fixed race condition during split sub-tracks and output by chapter
…ssing Adding leading zeros in chapters nubmers in output filenames when splitting by chapters
Owner
|
@1337joe , thank you for patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The line immediately above the line where the logger is initialized (
properties = current.loadAppProperties();) can cause logging to occur. Withloggernot initialized this throws a NPE, but this happens in a static initializer and causes the class to not load, producing aNoClassDefFoundErrorinstead of a more helpful stack trace.As evidenced by the missing path.properties, when installing the application from the AUR the application paths don't resolve as the code expected.
Changes:
As far as I've experienced the bug, this fixes #380 for Linux. I suspect the
getAppPath()changes I made for Linux could be applied to other platforms but without a way to test that I wasn't going to commit that change.