Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate whether an app is bought or not #396

Closed
rugk opened this issue Feb 14, 2018 · 5 comments
Closed

Indicate whether an app is bought or not #396

rugk opened this issue Feb 14, 2018 · 5 comments

Comments

@rugk
Copy link

rugk commented Feb 14, 2018

Expected behaviour

When an app is not bought:

  • the money may be highlighted
  • the "Download" button may instead be labeled "Buy".
  • also, when clicking on it, it may redirect to Google Play. (does not do so in my tests, think this was the behavior in previous versions)

Actual behaviour

In my test I could click on "Download", but it more or less did not start the download. Just canceled it without any feedback.

Steps to reproduce

  1. Go to a app you have to pay for.

Info about your device

LineageOS 14.1/Android 7

@yeriomin
Copy link
Owner

This can probably be done.

I don't have paid apps on any of my accounts. I can build you a modified apk which would most likely detect if the app is bought. Would you be willing to test it?

@rugk
Copy link
Author

rugk commented Feb 18, 2018

Yeah, I can test it.

@yeriomin
Copy link
Owner

@rugk Done. "Download" button should become "Buy" button on non-purchased paid apps, if my guess is right. Tapping it should show an app chooser for the paid app url to let the user choose between a browser and the play store app. I didn't bother with the long-press menu or anything else, lets test it first.

Thanks in advance.

app-release.zip

@rugk
Copy link
Author

rugk commented Feb 24, 2018

Cannot install it as I've installed the official version from f-Droid. Can you provide a build with a different package name, so I can install it side by side?

yeriomin added a commit that referenced this issue May 16, 2018
@yeriomin yeriomin added this to the 0.41 milestone May 16, 2018
@yeriomin
Copy link
Owner

Unfortunately, this has to be rolled back. The implementation I made is not reliable enough. Most likely, Play Store app operates on an assumption that it either buys all the apps itself, or gets push notifications when the apps are bought. Yalp Store can not do that. Checking if the app is purchased by attempting a download every time is not a good solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants