This repository was archived by the owner on Apr 23, 2020. It is now read-only.
library structures ~ 끝 (ref #144) #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bumkeyy
reviewed
Apr 20, 2020
|
|
||
| Note that it's possible to define many types in the global scope when writing a global declaration file. | ||
| We strongly discourage this as it leads to possible unresolvable name conflicts when many declaration files are in a project. | ||
| 전역 선언 파일을 작성할 때, 전역 스코프에 많은 타입을 정의할 수 있다는 점을 유의하세요. |
There was a problem hiding this comment.
Suggested change
| 전역 선언 파일을 작성할 때, 전역 스코프에 많은 타입을 정의할 수 있다는 점을 유의하세요. | |
| 전역 선언 파일을 작성할 때, 전역 스코프에 여러 개의 타입을 정의할 수 있다는 점을 유의하세요. |
There was a problem hiding this comment.
아래가 좀 더 잘 읽히지 않나요..? 의미는 둘 다 같습니다 😄
There was a problem hiding this comment.
잘 읽히기는 한데 의미상.... 좀 더 생각해볼게요 ㅎㅎ
bumkeyy
reviewed
Apr 20, 2020
| Note that it's possible to define many types in the global scope when writing a global declaration file. | ||
| We strongly discourage this as it leads to possible unresolvable name conflicts when many declaration files are in a project. | ||
| 전역 선언 파일을 작성할 때, 전역 스코프에 많은 타입을 정의할 수 있다는 점을 유의하세요. | ||
| 많은 선언 파일이 프로젝트 내에 있을 때, 해결할 수 없는 이름 충돌이 발생할 수 있으므로 이를 사용하지 않는 것이 좋습니다. |
There was a problem hiding this comment.
Suggested change
| 많은 선언 파일이 프로젝트 내에 있을 때, 해결할 수 없는 이름 충돌이 발생할 수 있으므로 이를 사용하지 않는 것이 좋습니다. | |
| 선언 파일이 프로젝트 내에 여러 개 있을 때, 해결할 수 없는 이름 충돌이 발생할 수 있으므로 이를 사용하지 않는 것이 좋습니다. |
bumkeyy
reviewed
Apr 20, 2020
bumkeyy
reviewed
Apr 20, 2020
bumkeyy
reviewed
Apr 20, 2020
Co-Authored-By: Kibeom Kwon <kgbum2222@gmail.com>
Co-Authored-By: Kibeom Kwon <kgbum2222@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
리뷰 부탁드립니다