This repository has been archived by the owner on May 25, 2019. It is now read-only.
Fix for usemin JS path that ignores Babel transpilation #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running `grunt build`, `grunt-usemin` builds a flow for .js files starting with `scripts` directory that contains not transpiled ES6 code. The transpilation (`grunt babel` task) puts transpiled files into `.tmp` directory. It happens before the first step in js flow (`concat`) is run. Thus, the transpilation works fine, but it's result is ignored and not transpiled files are used in `usemin` flow that ends up in target `dist` directory. Fixes yeoman#580.
eddiemonge
added a commit
that referenced
this pull request
Sep 21, 2015
Fix for usemin JS path that ignores Babel transpilation
|
Thanks! 👍 |
|
Thank you |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
grunt build,grunt-useminbuilds a flow for .js files starting withscriptsdirectory that contains not transpiled ES6 code.The transpilation (
grunt babeltask) puts transpiled files into.tmpdirectory. It happens before the first step in js flow (concat) is run.Thus, the transpilation works fine, but it's result is ignored and not transpiled files are used in
useminflow that ends up in targetdistdirectory.The fix changes the working directory where
useminstarts its flow to the destination directory of Babel transpilation.Fixes #580.