Add support for Babel #543
Conversation
|
Hey, thanks for the awesome PR 👍 The team decided to completely replace CoffeeScript with Babel, would you care to add that to your PR too? |
|
Will do |
|
This might be pushing it, but I could make the change that Babel is always included. If people do not want to use ES6 features, Babel would just pass the file right through without transforming anything. It would simplify the repo a bit more and encourage people to start using ES6+. |
|
Nah. I don't really know if all-day users would like that. Generally I don't like it if my build system is cluttered with things I don't use (in case they wouldn't use ES6), so I don't think they will eighter :/ |
|
Alright, removed CoffeeScript |
| 'sass:server'<% } else { %> | ||
| 'copy:styles'<% } %> | ||
| ], | ||
| test: [<% if (coffee) { %> | ||
| 'coffee'<% } %><% if (coffee && !includeSass) { %>,<% } %><% if (!includeSass) { %> | ||
| test: [<% if (babel) { %> |
|
Any reason why you guys want to remove CoffeeScript? Does it apply to other generators? |
|
CoffeeScript was created to patch some shortcomings of JavaScript (other than to provide some syntactic sugar). Now that we have an ES6 transpiler, there's no real need to support CoffeeScript anymore. We generally advise using plain JS over CoffeeScript because it's native (i.e. new features will be faster), the barrier of entry is lower (e.g. Atom being written in CS increases the barrier) and, in my opinion, there is less and less reason for it to exist. Yes, we'll probably drop it from other generators as well, eventually. |
| done(); | ||
| }); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Should probably test the babel option in some way
There was a problem hiding this comment.
ping? I just think that we should at least have a test for the babel option.
|
I like this 👍 @silvenon WDYT? Good to go? |
|
LGTM for a merge. Side: It's pretty great to see the Babel community proactively helping existing tools improve their ES6 support. Thanks a lot @thejameskyle! |
|
@silvenon In agreement regarding our general dropping of CS. Now might be a good time for us to open issues for any generators with remaining CS support to consider switching those over to ES6 too. |
|
@addyosmani good idea. Done. |
|
I tried it, seems to work fine. Very good job, @thejameskyle, thanks a lot 👍 I would even go as far as not making Babel optional, because it's just JavaScript, but this will do perfectly for now. |
|
👍 |
|
Thanks guys! |
Sure! 👍 Thanks @thejameskyle!
If that's the plan maybe we should consider writing about it at some point too? (a blogpost I mean) It's a change that significantly impacts our users and it's all about shiny new technology. There's much interesting stuff going on in the world of ES2015-tooling these days. |
|
You might also want to switch to eslint with babel-eslint as the parser for better ES6/ES7/JSX/etc support |
|
Thanks for the tip! I've just seen it recently, will check it out 👍 |
No description provided.