-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Compile all html files in views and its subfolders #111
Conversation
The `.editorconfig` set the indent style to 4 spaces, while the `.jshintrc` and templates were using two spaces.
Update editorconfig to use 2 spaces indention
Test runner fix for Windows
Copy .gif, .webp to dist
@btford what do you think ? |
I think it needs a test. It'd be great if you would write a test that shows this fix works, otherwise I'll get to it before the next release. |
If you just concat the html files won't you loose reference to template path which is essential to $templateCache? |
@luisbug this isn't concating (as far as I can tell), just minifying. Unless someone wants to own rebasing and testing this, I'm going to close it. I'm not convinced that this is worth the trouble quite yet, especially in light of the issues htmlmin has with custom tags/attributes. |
@btford |
@@ -9,7 +9,7 @@ root = true | |||
|
|||
# Change these settings to your own preference | |||
indent_style = space | |||
indent_size = 4 | |||
indent_size = 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this being changed?
@rhacker can you fix the merge conflict and address the comments? |
@rhacker still there? |
This is stale. Closing. Looks like #277 might be a good solution. |
No description provided.