Adding typescript support to generator-angular

[awk]

This is largely based upon an earlier pull request (#539).

It's updated for recent changes in generator-angular since that pull request was last updated. This flavor also uses tad and grunt-tsd to retrieve typescript definition files from the defintelyTyped repo instead of retrieving the definitions via bower_components.

[nzamosenchuk]

Very important thing is missing in Gruntfile.js generated with --typescript. Actual typescript task is not referenced and thus, no JS generated.
Need to manually update Gruntfile.js, and add the following typescript references to concurrent task:

    concurrent: {
      server: [
        'typescript',
        'sass:server',
        'copy:styles'        
      ],
      test: [
        'typescript',
        'copy:styles'
      ],
      dist: [
        'typescript',
        'sass',
        'copy:styles',
        'imagemin',
        'svgmin'
      ]
    },

[awk]

I'm not seeing this problem - if I run yo angular --typescript and accept the default options (or even if I choose not to use SASS) the resulting Gruntfile.js has entries for typescript in the concurrent:server task.

Can you make sure you've applied this pull request correctly?

[nzamosenchuk]

Sorry, looks to be a temporary glitch on my side. I've made the clean installation from scratch again (updating the npm, cleaning all the caches and all the stuff) and everything is fine now.

Thanks for great job done!

[eddiemonge]

yeoman/generator-karma#77 (comment)

[LunarDevelopment]

👍 Is this happening soon ?

[awk]

There hasn't been any real interest from the comitters for generator-angular - in the meantime I've created https://www.npmjs.com/package/generator-angular-typescript which is essentially this pull request 'made real'.

[eddiemonge]

I've been feeling lately, more and more, that the correct thing is to strip out typescript/coffeescript/precompilers in general, make this fully composable and then either create (or let others do it) generators that add thos to this. Still not sure how that is going to work though

[awk]

I'd be more than happy to take on the Typescript implementation part - once the composable part of the generator is worked out.

I agree with you though that working out that composable mechanism is going to be tough.

[ilubnon]

Hello,

When using the option --typescript, my project does not add support typescript, works only for coffeescript.

$ yo angular --typescript // not working.

$ yo angular --coffee // work's fine.

Also, even creating a project "default" and create controller with option --typescript, does not working.

$ yo angular: controller user --typescript

I will appreciate your help

My npm packages and versions:

$ npm list -g --depth=0
  /usr/local/lib
  ├── babel@5.8.23
  ├── bower@1.5.3
  ├── coffee-script@1.10.0
  ├── express@4.13.3
  ├── express-generator@4.13.1
  ├── generator-angular@0.12.1
  ├── generator-angular-typescript@0.11.2
  ├── generator-karma@1.0.0
  ├── generator-karma-typescript@1.0.0
  ├── grunt@0.4.5
  ├── grunt-cli@0.1.13
  ├── grunt-karma@0.12.1
  ├── jasmine-core@2.3.4
  ├── jshint@2.8.0
  ├── karma@0.13.10
  ├── latest-version@1.0.1
  ├── npm@3.3.5
  ├── phantomjs@1.9.18
  ├── tsd@0.6.5
  ├── typescript@1.6.2
  └── yo@1.4.8

Version Node and NPM

$ node -v && npm -v
  v4.1.2
  3.3.5

[diwadu]

Have the same issue as ilubnon, can generate only coffee files but not ts.

Node & NPM versions

$ node -v && npm -v
v4.2.1
2.14.7

[awk]

My commit was never merged - unless you're building from my branch those options don't work.

Alternatively you can install my fork of this repo https://www.npmjs.com/package/generator-angular-typescript and then you can do yo angular-typescript --typescript

[diwadu]

Thanks for the info. After lot of perturbations i installed finally your version, seems that working, creating app skeleton horribly long, but i suppose i have something wrong with versions of npm & git. Appreciate your work, i hope that TS support will appear soon in official version. Cheers!

[marcalj]

Thanks @awk I'm using generator-angular-typescript in the meantime. Let's see if it's easy to migrate a big app :)

[marcalj]

Hey @awk I can't add issues on your repo. It's always creating the app on my root user folder! Not the current one! How can I add an issue on your repo? Thanks!

[eddiemonge]

@marcalj do you have a .yo-rc.json in your root user folder? Are you running the yo command as sudo?

[eddiemonge]

@awk @marcalj @diwadu awk: your changes were merged. Haven't done a release for them yet though. To use the typescript option you have to install the git master version: npm i -g yeoman/generator-angular

[nzamosenchuk]

grunt test doesn't work with typescript-based app. They simply are not found by Karma.
Need to manually update karma.conf.js path to JS files. That are stored in '.tmp/...' after typescript preprocessing.

[marcalj]

@eddiemonge Removing yo-rc.json fixes the problem, thanks!