Merge pull request #7 from yeoji/fix/4/multi-select-shift

Fix broken multi select when new image is reloaded

.github/workflows/main.yml

@@ -8,7 +8,17 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout 🛎️
-        uses: actions/checkout@v2.3.1
+        uses: actions/checkout@v4
+
+      - name: Set Node.js 18.x
+        uses: actions/setup-node@v4
+        with:
+          node-version: 18.x
+
+      - name: Setup Yarn 🧶
+        run: |
+          corepack enable
+          yarn set version stable
 
       - name: Install and Build 🔧
         run: |

.github/workflows/pull-request.yml

@@ -0,0 +1,36 @@
+name: Build Artifact on PR
+on:
+  pull_request:
+    types: 
+      - opened
+      - synchronize
+    branches:
+      - master
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout 🛎️
+        uses: actions/checkout@v4
+
+      - name: Set Node.js 18.x
+        uses: actions/setup-node@v4
+        with:
+          node-version: 18.x
+
+      - name: Setup Yarn 🧶
+        run: |
+          corepack enable
+          yarn set version stable
+
+      - name: Install and Build 🔧
+        run: |
+          yarn install
+          yarn build
+      
+      - name: Upload artifacts 📦
+        uses: actions/upload-artifact@v4
+        with:
+          name: gh-pages
+          path: dist
+          retention-days: 5

.gitignore

@@ -2,3 +2,11 @@ node_modules
 dist
 .cache
 .DS_Store
+
+.yarn/*
+!.yarn/cache
+!.yarn/patches
+!.yarn/plugins
+!.yarn/releases
+!.yarn/sdks
+!.yarn/versions

.yarnrc.yml

@@ -0,0 +1,5 @@
+compressionLevel: mixed
+
+enableGlobalCache: false
+
+nodeLinker: node-modules

package.json

@@ -13,6 +13,7 @@
   },
   "dependencies": {
     "jquery": "^3.6.0",
-    "jszip": "^3.10.1"
+    "jszip": "^3.10.1",
+    "node-gyp": "^10.0.1"
   }
 }

src/spritecow/SpriteCanvasView.js

@@ -141,19 +141,20 @@ var SelectArea = (function() {
 		this._$eventArea = $eventArea;
 		this._highlight = highlight;
 		this._listeners = [];
+
+		this.createListeners();
 	}
 
 	var SelectAreaProto = SelectArea.prototype = new MicroEvent;
-	
-	SelectAreaProto.activate = function() {
+
+	SelectAreaProto.createListeners = function() {
 		var selectArea = this,
 			rect = new Rect(0, 0, 0, 0),
 			startX, startY,
 			startPositionX, startPositionY,
 			isDragging,
 			$document = $(document);
-
-
+
 		selectArea._listeners.push([
 			selectArea._$eventArea, 'mousedown', function(event) {
 				if (event.button !== 0) { return; }
@@ -196,6 +197,10 @@ var SelectArea = (function() {
 				selectArea._highlight.hide();
 			}
 		]);
+	}
+
+	SelectAreaProto.activate = function() {
+		var selectArea = this;
 
 		selectArea._listeners.forEach(function(set) {
 			set[0].bind.apply( set[0], set.slice(1) );
@@ -244,8 +249,7 @@ class SpriteCanvasView {
 				spriteRect = spriteCanvas.expandToSpriteBoundry(rect);
 
 				spriteCanvasView._handleSelectedSprite(clickedRect, spriteRect);
-			}
-			else {
+			} else {
 				spriteCanvasView._unselectAllSprites();
 			}
 		});
@@ -289,6 +293,7 @@ SpriteCanvasViewProto._selectSprite = function(clickedRect, spriteRect) {
 
 SpriteCanvasViewProto._unselectAllSprites = function() {
 	this._selectedSprites.forEach(sprite => sprite.unselect());
+	this._selectedSprites = [];
 }
 
 SpriteCanvasViewProto.setTool = function(mode) {