Add C++23 support with tl::expected for error handling and refactor c… #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onstructors for improved clarity
There was a problem hiding this comment.
Pull request overview
This PR migrates the codebase from std::expected to tl::expected for error handling, adds default constructors for several decoder classes, and fixes a thread-safety issue with atomic double operations.
Changes:
- Replaced all
std::expectedandstd::unexpectedwithtl::expectedandtl::unexpectedthroughout headers and implementation files - Added tl::expected v1.1.0 library dependency via FetchContent in CMakeLists.txt
- Added default constructors for SpikeSorter, KalmanDecoder, and LinearDecoder classes
- Fixed thread-safety issue with atomic double accumulation in realtime_demo.cpp using compare-exchange loop
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| CMakeLists.txt | Added tl::expected library dependency (v1.1.0) from TartanLlama/expected repository |
| include/phantomcore/neural_net_decoder.hpp | Updated includes and all function signatures returning expected types to use tl::expected |
| include/phantomcore/gpu_decoder.hpp | Updated includes and all function signatures returning expected types to use tl::expected |
| src/neural_net_decoder.cpp | Updated all expected type usage and unexpected returns to use tl:: namespace |
| src/gpu_decoder.cpp | Updated all expected type usage and unexpected returns to use tl:: namespace |
| src/spike_detector.cpp | Added default constructor for SpikeSorter delegating to Config-based constructor |
| src/kalman_decoder.cpp | Added default constructors for KalmanDecoder and LinearDecoder |
| examples/realtime_demo.cpp | Fixed atomic double accumulation with compare_exchange_weak loop for thread safety |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The CI was failing because CTest was picking up all tests from dependencies (Eigen, tl::expected, Google Benchmark) instead of just PhantomCore tests. Most dependency tests weren't built, causing them to be reported as failures. Changes: - Disable BUILD_TESTING for all dependencies in CMakeLists.txt - Restore BUILD_TESTING after dependencies are fetched - Add platform-specific test commands in CI workflow (Linux vs Windows) - Tests now properly run only PhantomCore tests (53 tests instead of 969) All 53 PhantomCore tests now pass successfully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.