Use bundle to execute commands #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yegor256 please, pay attention to this pull request |
yegor256
reviewed
Jul 10, 2017
bash/deploy.sh
Outdated
| if [ -r ${DEPLOY_CONFIG} ]; then | ||
| jekyll build --config _config.yml,${DEPLOY_CONFIG} | ||
| if [ -r ${BUNDLE} ]; then | ||
| if [ -r ${DEPLOY_CONFIG} ]; then |
There was a problem hiding this comment.
@dmydlarz looks like code duplication for me. How about passing $5 as bundle exec and just using it here as a prefix.
yegor256
reviewed
Jul 10, 2017
bin/jgd
Outdated
| @@ -22,6 +23,7 @@ fail 'branch-from can\'t be empty' if branch_from.empty? | |||
| fail 'config can\'t be empty' if config.empty? | |||
| url = opts[:url] | |||
| url = `git config --get remote.origin.url`.strip if url.empty? | |||
| bundle = opts[:bundle] | |||
There was a problem hiding this comment.
@dmydlarz here: bundle = opts[:bundle] ? 'bundle exec' : ''
yegor256
reviewed
Jul 10, 2017
|
@dmydlarz see my comments above |
|
@yegor256 what do you think now? |
|
@rultor try to merge |
|
@yegor256 I am not into RubyGems at all. Is it gonna be published there somehow automatically? |
|
@rultor release, tag is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add flag to make it possible to run build commands via bundle.
Additionally add build.sh script. I spend some time figuring out how to build & install locally.