Add addtional CLI option --branch-from #24
Conversation
|
Hey there -- Thanks for this gem -- found it pretty helpful but i discovered i needed a little more flexibility around which branches i could push to / from. This change got it working for me the way i wanted so happy to share it back with you if you think others would find it interesting. |
|
@worace Thanks for the pull request, let me find a reviewer.. |
|
@xxd3vin i think that is similar but if I understand correctly doesn't let you specify both custom target and source branches? so in the current case you could specify to build to a custom branch but it would always build from |
|
@worace I'm sorry, you are right, I think I misunderstood you. I look into this commit, it's OK. |
|
@davvd Where is the code reviewer? |
| @@ -8,7 +8,7 @@ Gem::Specification.new do |s| | |||
| s.rubygems_version = '2.2.2' | |||
| s.required_ruby_version = '>= 1.9.3' | |||
| s.name = 'jgd' | |||
| s.version = '2.0.snapshot' | |||
| s.version = '2.1.0' | |||
There was a problem hiding this comment.
@worace please, put it back. it should be 2.0.snapshot
|
@worace I made one comment to the PR, please check it |
This supports a little more flexibility in which branches can be used for deploying and building. Specifically, it lets a user build from some non-master branch and push to a master branch, which is useful if you're deploying to the standard myname.github.io. Example: jgd --branch master --branch-from source
|
@yegor256 thanks for taking a look! I put the version back and also went ahead and squashed my commits into 1 |
@xxd3vin still looking for one... |
|
@yegor256 review this pls (it's a rather short pull request) |
|
@rultor merge |
|
@rultor release, tag is |
|
@rultor deploy |
This supports a little more flexibility in which
branches can be used for deploying and building.
Specifically, it lets a user build from some non-master
branch and push to a master branch, which is useful
if you're deploying to the standard myname.github.io.
Example:
jgd --branch master --branch-from source