-
Notifications
You must be signed in to change notification settings - Fork 85
add fallbacks to built-ins to :LspHover/GotoDefintion #689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As discussed with @jclsn at jclsn/vimconfig@d62cc05
|
Maybe mention that the hover fallback is most useful for file types such as python that come with decent For some LS, like CMake's neocmakelsp or cmake-language-server, a dedicated keywordprg such as https://github.com/bfrg/vim-cmake-help can serve as complement for missing built-in functionality |
|
I think this fallback should be made optional too btw. Maybe add a config item. It might be confusing if this is the default behavior. The hover could also be made optional per-server. It is annoying in C, but in Python it's actually nice to have both. |
I made both fallbacks opt-ins.
The standard |
|
Nice, this look pretty complete to me now! :) Can also always be improved later |
|
Getting an error here in YAML files when trying to hover |
|
Thank you, another forgotten return. Should be fixed |
* add fallbacks to built-ins to :LspHover/GotoDefintion As discussed with @jclsn at jclsn/vimconfig@d62cc05 * only fallback for custom &keywordprg as kindly pointed out by @jclsn * fallback if no definition found as kindly suggested by @jclsn * fix typo (peek turning into peekSymbol elsewhere) * make fallbacks opt-in and document them * doc: expand recommended set-up * use built-in tjump map * hover: fix typo * remove redundant check * add back forgotten return * add back forgotten return statement * use built-in tjump map * address suggestions kindly pointed out by @yegappan * use more correct wording (as tags are neither tied to C nor ctags) * use more robust map instead of command as suggested by @yegappan
using the mappings the selection dialog would not accept user input; this amends [0] [0]: yegappan#689
As discussed with @jclsn at jclsn/vimconfig@d62cc05