Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async load registry #580

Merged
merged 3 commits into from
Sep 5, 2023
Merged

Async load registry #580

merged 3 commits into from
Sep 5, 2023

Conversation

BobTheBuidler
Copy link
Collaborator

Related issue # (if applicable):

What I did:

removed all threads involved with loading vaults + strats and replaced with async logic

How I did it:

How to verify it:

Checklist:

  • I have tested it locally and it works
  • I have included any relevant documentation for the repo maintainers
  • (If fixing a bug) I have added a test to the test suite to test for this particular bug

Adding a Network

If the purpose of your PR is to add support for a new network, please copy the checklist from here into this PR conversation, and use it to track your changes.

Copy link
Contributor

@0xBasically 0xBasically left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm tested locally

@BobTheBuidler BobTheBuidler merged commit 11d835e into master Sep 5, 2023
0 of 24 checks passed
@BobTheBuidler BobTheBuidler deleted the async-load-registry branch September 5, 2023 16:20
BobTheBuidler added a commit that referenced this pull request Sep 5, 2023
0xBasically added a commit that referenced this pull request Sep 6, 2023
* Revert "Async load registry (#580)"

This reverts commit 11d835e.

* Revert "fix: staking rewards apy KeyError (#590)"

This reverts commit 555fbaf.

* Revert "fix: adapt staking pools to async events pr (#588)"

This reverts commit 3b6eab6.

* Revert "fix: async reports (#586)"

This reverts commit 4d4b0df.

* Revert "fix: opti s3 (#585)"

This reverts commit 667a27d.

* Revert "fix: s3 mainnet after asynced load_streams (#584)"

This reverts commit 9711c1a.

* fix: s3 await

---------

Co-authored-by: 0xBasically <0xBasic@yearn.finance>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants