fix: Handle price failure case (#600)

* fix: price err tvl edge case * chore: cleanup
yearn · Sep 7, 2023 · 5223183 · 5223183
1 parent 9e911d5
commit 5223183
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/yearn/v1/vaults.py b/yearn/v1/vaults.py
@@ -159,5 +159,6 @@ async def tvl(self, block=None):
         except yPriceMagicError as e:
             if not isinstance(e.exception, PriceError):
                 raise e
+            price = None
         tvl = total_assets * price / 10 ** await self.vault.decimals.coroutine(block_identifier=block) if price else None
         return Tvl(total_assets, price, tvl) 
diff --git a/yearn/v2/vaults.py b/yearn/v2/vaults.py
@@ -297,10 +297,7 @@ async def tvl(self, block=None):
                 raise e
             price = 0
 
-        # NOTE: which one of these do we use? idk, must check
-        tvl = total_assets * price / 10 ** self.vault.decimals(block_identifier=block)
         tvl = total_assets * price / await ERC20(self.vault, asynchronous=True).scale if price else None
-
         return Tvl(total_assets, price, tvl)
 
     @cached_property