Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify so that each log entry is written in one line with properly p… #33

Merged
merged 2 commits into from
Sep 14, 2020
Merged

Conversation

a5hlynx
Copy link
Contributor

@a5hlynx a5hlynx commented Sep 13, 2020

Hi Yogesh-san,

As far as I try the latest version of UnifiedLogReader in LOG_DEFAULT mode, the timestamp of each log entry is not properly written.
Also, I found the followings about the line break, both of which I believe are not what you originally intented.

  • In LOG_DEFAULT, the first log entry starts right after the header without line break, and some log entries contain line breaks within themselves.
  • In TSV_ALL, the header and all the log entries are written in one line.

I modified the code so as to eliminate the issues above, and if my modification seems OK to you, can you merge it to your branch?

Best regards,
Yuya Hashimoto

@ydkhatri ydkhatri merged commit 9bfa5be into ydkhatri:master Sep 14, 2020
@a5hlynx a5hlynx changed the title modify so as to each log entry is written in one line with properly p… modify so that each log entry is written in one line with properly p… Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants