Skip to content

fix segfault when called from older version #9880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

adameat
Copy link
Member

@adameat adameat commented Sep 30, 2024

Changelog entry

fix segfault when called from older version

Changelog category

  • Bugfix
  • Not for changelog (changelog entry is not required)

@adameat adameat added the area/ui UI/Embedded UI related issues label Sep 30, 2024
@adameat adameat self-assigned this Sep 30, 2024
@adameat adameat requested a review from a team as a code owner September 30, 2024 04:01
@adameat adameat enabled auto-merge (squash) September 30, 2024 04:03
Copy link

github-actions bot commented Sep 30, 2024

2024-09-30 04:05:01 UTC Pre-commit check linux-x86_64-relwithdebinfo for 925084a has started.
2024-09-30 04:05:12 UTC Artifacts will be uploaded here
2024-09-30 04:08:03 UTC ya make is running...
🔴 2024-09-30 05:01:28 UTC Build failed, see the logs.

Copy link

github-actions bot commented Sep 30, 2024

2024-09-30 04:05:06 UTC Pre-commit check linux-x86_64-release-asan for 925084a has started.
2024-09-30 04:05:16 UTC Artifacts will be uploaded here
2024-09-30 04:08:06 UTC ya make is running...
🔴 2024-09-30 04:47:17 UTC Build failed, see the logs.

Copy link

github-actions bot commented Sep 30, 2024

2024-09-30 05:58:02 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0ce21c5 has started.
2024-09-30 05:58:12 UTC Artifacts will be uploaded here
2024-09-30 06:04:41 UTC ya make is running...
🟡 2024-09-30 09:19:47 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14819 13336 0 2 1378 103

2024-09-30 09:21:16 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-30 09:35:27 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
98 (only retried tests) 8 0 0 0 90

🟢 2024-09-30 09:35:33 UTC Build successful.
🟢 2024-09-30 09:35:55 UTC ydbd size 2.8 GiB changed* by +16 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: e8a4121 merge: 0ce21c5 diff diff %
ydbd size 3 001 690 016 Bytes 3 001 690 032 Bytes +16 Bytes +0.000%
ydbd stripped size 477 384 104 Bytes 477 384 104 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 30, 2024

2024-09-30 05:58:16 UTC Pre-commit check linux-x86_64-release-asan for 0ce21c5 has started.
2024-09-30 05:58:26 UTC Artifacts will be uploaded here
2024-09-30 06:04:55 UTC ya make is running...
🟡 2024-09-30 09:02:54 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10379 10076 0 106 54 143

🟢 2024-09-30 09:03:46 UTC Build successful.
🟢 2024-09-30 09:04:24 UTC ydbd size 5.7 GiB changed* by -80 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: e8a4121 merge: 0ce21c5 diff diff %
ydbd size 6 085 532 256 Bytes 6 085 532 176 Bytes -80 Bytes -0.000%
ydbd stripped size 1 520 547 504 Bytes 1 520 547 440 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@adameat adameat merged commit ea6dfcc into ydb-platform:main Sep 30, 2024
10 checks passed
adameat added a commit to adameat/ydb that referenced this pull request Oct 1, 2024
pashandor789 pushed a commit to pashandor789/ydb that referenced this pull request Oct 1, 2024
adameat added a commit to adameat/ydb that referenced this pull request Oct 4, 2024
@adameat adameat deleted the fix-autocomplete-segfault branch November 14, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui UI/Embedded UI related issues bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants