Skip to content

[KQP] CBO hints warnings added #9701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2024
Merged

[KQP] CBO hints warnings added #9701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ydb/core/kqp/opt/logical/kqp_opt_log.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,9 @@ class TKqpLogicalOptTransformer : public TOptimizeTransformerBase {
public:
TStatus DoTransform(TExprNode::TPtr input, TExprNode::TPtr& output, TExprContext& ctx) override {
auto status = TOptimizeTransformerBase::DoTransform(input, output, ctx);

for (const auto& hint: KqpCtx.GetOptimizerHints().GetUnappliedHintStrings()) {
YQL_CLOG(WARN, ProviderYdb) << "Unapplied hint: " + hint;
for (const auto& hint: KqpCtx.GetOptimizerHints().GetUnappliedString()) {
ctx.AddWarning(YqlIssue({}, TIssuesIds::YQL_UNUSED_HINT, "Unapplied hint: " + hint));
}

return status;
Expand Down
2 changes: 1 addition & 1 deletion ydb/library/yql/core/cbo/cbo_optimizer_new.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ const TBaseProviderContext& TBaseProviderContext::Instance() {
return staticContext;
}

TVector<TString> TOptimizerHints::GetUnappliedHintStrings() {
TVector<TString> TOptimizerHints::GetUnappliedString() {
TVector<TString> res;

for (const auto& hint: JoinAlgoHints->Hints) {
Expand Down
2 changes: 1 addition & 1 deletion ydb/library/yql/core/cbo/cbo_optimizer_new.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ struct TOptimizerHints {
std::shared_ptr<TJoinAlgoHints> JoinAlgoHints = std::make_shared<TJoinAlgoHints>();
std::shared_ptr<TJoinOrderHints> JoinOrderHints = std::make_shared<TJoinOrderHints>();

TVector<TString> GetUnappliedHintStrings();
TVector<TString> GetUnappliedString();

/*
* The function accepts string with three type of expressions: array of (JoinAlgo | Card | JoinOrder):
Expand Down