KIKIMR-20714 Удаляем LongTxService в тестах #970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note This is an automated comment that will be appended during run. 🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit dfacff4.
🔴 linux-x86_64-release-asan: some tests FAILED for commit dfacff4.
|
nsofya
reviewed
Jan 14, 2024
ydb/services/ydb/ut/ya.make
Outdated
| @@ -22,7 +22,6 @@ SRCS( | |||
| ydb_scripting_ut.cpp | |||
| ydb_table_ut.cpp | |||
| ydb_stats_ut.cpp | |||
| ydb_long_tx_ut.cpp | |||
There was a problem hiding this comment.
Давай в рамках того пр не будет вообще service/ydb трогать. Удалим эти тесты вместе с апи.
nsofya
reviewed
Jan 14, 2024
ydb/core/kqp/ut/common/columnshard.h
Outdated
| NYdb::NTable::TSession Session; | ||
|
|
||
| public: | ||
| TTestHelper(const TKikimrSettings& settings); | ||
| TKikimrRunner& GetKikimr(); | ||
| NYdb::NTable::TSession& GetSession(); | ||
| void CreateTable(const TColumnTableBase& table); | ||
| void InsertData(const TColumnTable& table, TTestHelper::TUpdatesBuilder& updates, const std::function<void()> onBeforeCommit = {}, const NYdb::EStatus opStatus = NYdb::EStatus::SUCCESS); | ||
| void InsertData(const TColumnTable& table, TTestHelper::TUpdatesBuilder& updates, const std::function<void()> onBeforeCommit = {}, const Ydb::StatusIds_StatusCode& opStatus = Ydb::StatusIds::SUCCESS); |
There was a problem hiding this comment.
Давай эту функцию вообще уберем. Потому что UNUSED на параметр как-то неаккуратно выходит. Замени использование на BulkUpsert, чтобы ни у кого не было сомнений. Потом туда попробую какие-то хуки добавить
nsofya
previously approved these changes
Jan 14, 2024
nsofya
approved these changes
Jan 15, 2024
Closed
Closed
Merged
Merged
This was referenced Jan 25, 2024
This was referenced Feb 5, 2024
This was referenced Feb 6, 2024
This was referenced Feb 6, 2024
Merged
Merged
Merged
Merged
Merged
Closed
This was referenced Feb 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.