Skip to content

fix mvcc tests. use write id as row feature for conflicts resolving #9598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 23, 2024
Merged

fix mvcc tests. use write id as row feature for conflicts resolving #9598

merged 8 commits into from
Sep 23, 2024

Conversation

@ivanmorozov333
Copy link
Collaborator

@ivanmorozov333 ivanmorozov333 commented Sep 21, 2024

  • Bugfix

@github-actions
Copy link

github-actions bot commented Sep 21, 2024 •
edited
Loading

⚪ 2024-09-21 13:20:22 UTC Pre-commit check linux-x86_64-release-clang14 for 9d65c3c has started.
⚪ 2024-09-21 13:20:32 UTC Artifacts will be uploaded here
⚪ 2024-09-21 13:23:32 UTC ya make is running...
⚫ 2024-09-21 13:25:32 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Sep 21, 2024 •
edited
Loading

⚪ 2024-09-21 13:20:33 UTC Pre-commit check linux-x86_64-release-asan for 9d65c3c has started.
⚪ 2024-09-21 13:20:44 UTC Artifacts will be uploaded here
⚪ 2024-09-21 13:23:45 UTC ya make is running...
⚫ 2024-09-21 13:25:32 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Sep 21, 2024 •
edited
Loading

⚪ 2024-09-21 13:22:39 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9d65c3c has started.
⚪ 2024-09-21 13:22:49 UTC Artifacts will be uploaded here
⚫ 2024-09-21 13:25:30 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Sep 21, 2024 •
edited
Loading

⚪ 2024-09-21 13:26:55 UTC Pre-commit check linux-x86_64-release-clang14 for 4c2d95f has started.
⚪ 2024-09-21 13:27:03 UTC Artifacts will be uploaded here
⚪ 2024-09-21 13:30:02 UTC ya make is running...
🟢 2024-09-21 13:45:08 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Sep 21, 2024 •
edited
Loading

⚪ 2024-09-21 13:29:11 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4c2d95f has started.
⚪ 2024-09-21 13:29:22 UTC Artifacts will be uploaded here
⚪ 2024-09-21 13:32:30 UTC ya make is running...
🟡 2024-09-21 14:48:57 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39980 34379 0 6 5484 111

⚪ 2024-09-21 14:52:21 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-21 15:03:42 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
157 (only retried tests) 60 0 4 1 92

⚪ 2024-09-21 15:03:50 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-09-21 15:14:56 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
101 (only retried tests) 9 0 3 0 89

🟢 2024-09-21 15:15:02 UTC Build successful.
🟢 2024-09-21 15:15:45 UTC ydbd size 8.4 GiB changed* by +56.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 8ec93b0 merge: 4c2d95f diff diff %
ydbd size 9 044 913 968 Bytes 9 044 971 824 Bytes +56.5 KiB +0.001%
ydbd stripped size 489 466 536 Bytes 489 475 304 Bytes +8.6 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 21, 2024 •
edited
Loading

⚪ 2024-09-21 13:29:21 UTC Pre-commit check linux-x86_64-release-asan for 4c2d95f has started.
⚪ 2024-09-21 13:29:31 UTC Artifacts will be uploaded here
⚪ 2024-09-21 13:32:27 UTC ya make is running...
🔴 2024-09-21 15:21:56 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10620 10278 0 33 269 40

🟢 2024-09-21 15:22:50 UTC Build successful.
🟢 2024-09-21 15:23:23 UTC ydbd size 5.6 GiB changed* by +74.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 8ec93b0 merge: 4c2d95f diff diff %
ydbd size 6 063 001 616 Bytes 6 063 077 544 Bytes +74.1 KiB +0.001%
ydbd stripped size 1 516 681 744 Bytes 1 516 699 248 Bytes +17.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 22, 2024 •
edited
Loading

⚪ 2024-09-22 15:46:00 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1132c3c has started.
⚪ 2024-09-22 15:46:19 UTC Artifacts will be uploaded here
⚪ 2024-09-22 15:49:23 UTC ya make is running...
⚫ 2024-09-22 15:59:11 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Sep 22, 2024 •
edited
Loading

⚪ 2024-09-22 15:46:09 UTC Pre-commit check linux-x86_64-release-asan for 1132c3c has started.
⚪ 2024-09-22 15:46:19 UTC Artifacts will be uploaded here
⚪ 2024-09-22 15:49:12 UTC ya make is running...
⚫ 2024-09-22 15:59:11 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Sep 22, 2024 •
edited
Loading

⚪ 2024-09-22 15:47:11 UTC Pre-commit check linux-x86_64-release-clang14 for 1132c3c has started.
⚪ 2024-09-22 15:47:21 UTC Artifacts will be uploaded here
⚪ 2024-09-22 15:50:15 UTC ya make is running...
⚫ 2024-09-22 15:59:07 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Sep 22, 2024

⚪ 2024-09-22 16:00:52 UTC Pre-commit check linux-x86_64-release-clang14 for 56de6ef has started.

@github-actions
Copy link

github-actions bot commented Sep 22, 2024 •
edited
Loading

⚪ 2024-09-22 16:02:15 UTC Pre-commit check linux-x86_64-relwithdebinfo for 56de6ef has started.
⚪ 2024-09-22 16:02:44 UTC Artifacts will be uploaded here
⚪ 2024-09-22 16:05:48 UTC ya make is running...
⚫ 2024-09-22 16:32:21 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Sep 22, 2024 •
edited
Loading

⚪ 2024-09-22 16:03:22 UTC Pre-commit check linux-x86_64-release-asan for 56de6ef has started.
⚪ 2024-09-22 16:03:39 UTC Artifacts will be uploaded here
⚪ 2024-09-22 16:06:41 UTC ya make is running...
⚫ 2024-09-22 16:32:22 UTC Check cancelled

@ivanmorozov333 ivanmorozov333 added the rebase-and-check Rebase PR with the current base branch and check label Sep 22, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Sep 22, 2024
@github-actions
Copy link

github-actions bot commented Sep 22, 2024 •
edited
Loading

⚪ 2024-09-22 16:34:05 UTC Pre-commit check linux-x86_64-relwithdebinfo for e4dbc6f has started.
⚪ 2024-09-22 16:34:15 UTC Artifacts will be uploaded here
⚪ 2024-09-22 16:37:10 UTC ya make is running...
🟡 2024-09-22 17:42:05 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39979 34430 0 6 5449 94

⚪ 2024-09-22 17:45:25 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-22 17:56:36 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
106 (only retried tests) 13 0 2 1 90

⚪ 2024-09-22 17:56:44 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-09-22 18:07:50 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
99 (only retried tests) 7 0 2 0 90

🟢 2024-09-22 18:07:56 UTC Build successful.
🟡 2024-09-22 18:08:37 UTC ydbd size 8.4 GiB changed* by +273.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: dbe09f9 merge: e4dbc6f diff diff %
ydbd size 9 044 940 832 Bytes 9 045 220 808 Bytes +273.4 KiB +0.003%
ydbd stripped size 489 467 560 Bytes 489 483 624 Bytes +15.7 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 22, 2024 •
edited
Loading

⚪ 2024-09-22 16:34:34 UTC Pre-commit check linux-x86_64-release-asan for e4dbc6f has started.
⚪ 2024-09-22 16:34:44 UTC Artifacts will be uploaded here
⚪ 2024-09-22 16:37:37 UTC ya make is running...
🔴 2024-09-22 18:26:54 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10625 10436 0 44 41 104

🟢 2024-09-22 18:27:48 UTC Build successful.
🟢 2024-09-22 18:28:23 UTC ydbd size 5.6 GiB changed* by +63.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b2b16e8 merge: e4dbc6f diff diff %
ydbd size 6 063 106 856 Bytes 6 063 171 704 Bytes +63.3 KiB +0.001%
ydbd stripped size 1 516 711 888 Bytes 1 516 726 512 Bytes +14.3 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 22, 2024 •
edited
Loading

⚪ 2024-09-22 16:36:06 UTC Pre-commit check linux-x86_64-release-clang14 for e4dbc6f has started.
⚪ 2024-09-22 16:36:15 UTC Artifacts will be uploaded here
⚪ 2024-09-22 16:39:09 UTC ya make is running...
🟢 2024-09-22 16:46:50 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Sep 23, 2024 •
edited
Loading

⚪ 2024-09-23 04:35:20 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1e27812 has started.
⚪ 2024-09-23 04:35:30 UTC Artifacts will be uploaded here
⚪ 2024-09-23 04:38:26 UTC ya make is running...
⚫ 2024-09-23 04:50:49 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Sep 23, 2024 •
edited
Loading

⚪ 2024-09-23 04:35:21 UTC Pre-commit check linux-x86_64-release-clang14 for 1e27812 has started.
⚪ 2024-09-23 04:35:31 UTC Artifacts will be uploaded here
⚪ 2024-09-23 04:38:25 UTC ya make is running...
🟢 2024-09-23 04:44:58 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Sep 23, 2024 •
edited
Loading

⚪ 2024-09-23 04:35:39 UTC Pre-commit check linux-x86_64-release-asan for 1e27812 has started.
⚪ 2024-09-23 04:35:49 UTC Artifacts will be uploaded here
⚪ 2024-09-23 04:38:49 UTC ya make is running...
⚫ 2024-09-23 04:50:38 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Sep 23, 2024 •
edited
Loading

⚪ 2024-09-23 04:55:27 UTC Pre-commit check linux-x86_64-release-clang14 for 611f6b9 has started.
⚪ 2024-09-23 04:55:36 UTC Artifacts will be uploaded here
⚪ 2024-09-23 04:58:30 UTC ya make is running...
🔴 2024-09-23 05:01:20 UTC Build failed, see the logs.

@github-actions
Copy link

github-actions bot commented Sep 23, 2024 •
edited
Loading

⚪ 2024-09-23 04:55:32 UTC Pre-commit check linux-x86_64-release-asan for 611f6b9 has started.
⚪ 2024-09-23 04:55:42 UTC Artifacts will be uploaded here
⚪ 2024-09-23 04:58:36 UTC ya make is running...
⚫ 2024-09-23 05:06:16 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Sep 23, 2024 •
edited
Loading

⚪ 2024-09-23 04:55:35 UTC Pre-commit check linux-x86_64-relwithdebinfo for 611f6b9 has started.
⚪ 2024-09-23 04:55:45 UTC Artifacts will be uploaded here
⚪ 2024-09-23 04:58:42 UTC ya make is running...
⚫ 2024-09-23 05:06:16 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Sep 23, 2024 •
edited
Loading

⚪ 2024-09-23 05:07:40 UTC Pre-commit check linux-x86_64-release-asan for a2cd36a has started.
⚪ 2024-09-23 05:08:00 UTC Artifacts will be uploaded here
⚪ 2024-09-23 05:11:10 UTC ya make is running...
🔴 2024-09-23 07:48:33 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11916 11424 0 94 345 53

🟢 2024-09-23 07:49:34 UTC Build successful.
🟢 2024-09-23 07:50:09 UTC ydbd size 5.6 GiB changed* by +68.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 92caca9 merge: a2cd36a diff diff %
ydbd size 6 063 104 936 Bytes 6 063 174 912 Bytes +68.3 KiB +0.001%
ydbd stripped size 1 516 710 864 Bytes 1 516 726 640 Bytes +15.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 23, 2024 •
edited
Loading

⚪ 2024-09-23 05:10:00 UTC Pre-commit check linux-x86_64-release-clang14 for a2cd36a has started.
⚪ 2024-09-23 05:10:09 UTC Artifacts will be uploaded here
⚪ 2024-09-23 05:13:27 UTC ya make is running...

@github-actions
Copy link

github-actions bot commented Sep 23, 2024 •
edited
Loading

⚪ 2024-09-23 05:12:38 UTC Pre-commit check linux-x86_64-relwithdebinfo for a2cd36a has started.
⚪ 2024-09-23 05:12:48 UTC Artifacts will be uploaded here
⚪ 2024-09-23 05:16:08 UTC ya make is running...
🟡 2024-09-23 06:58:11 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41274 35670 0 6 5481 117

⚪ 2024-09-23 07:01:46 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-23 07:13:17 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
160 (only retried tests) 65 0 0 1 94

🟢 2024-09-23 07:13:24 UTC Build successful.
🟢 2024-09-23 07:14:06 UTC ydbd size 8.4 GiB changed* by +61.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 92caca9 merge: a2cd36a diff diff %
ydbd size 9 045 161 120 Bytes 9 045 224 016 Bytes +61.4 KiB +0.001%
ydbd stripped size 489 475 176 Bytes 489 483 624 Bytes +8.2 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 marked this pull request as ready for review September 23, 2024 08:05
@ivanmorozov333 ivanmorozov333 requested a review from a team as a code owner September 23, 2024 08:05
@maximyurchuk maximyurchuk merged commit 6862d3c into ydb-platform:main Sep 23, 2024
@ivanmorozov333 ivanmorozov333 deleted the mvcc_tests_fixes branch September 23, 2024 09:17
@GrigoriyPA GrigoriyPA mentioned this pull request Sep 24, 2024
Closed
@niksaveliev niksaveliev mentioned this pull request Sep 24, 2024
Merged
This was referenced Sep 25, 2024
Merged
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Oct 3, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Oct 8, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Oct 10, 2024
Merged
This was referenced Oct 21, 2024
Merged
Merged
fexolm pushed a commit to fexolm/ydb that referenced this pull request Oct 28, 2024
@ivanmorozov333 @fexolm
fix mvcc tests. use write id as row feature for conflicts resolving (y…
0a45c71 
…db-platform#9598)
@zverevgeny zverevgeny mentioned this pull request Jan 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zverevgeny zverevgeny zverevgeny approved these changes

Assignees

No one assigned

Labels

bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ivanmorozov333 @zverevgeny @maximyurchuk