Skip to content

YQ-3322 Move pg from common to purecalc #9512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 23, 2024
Merged

YQ-3322 Move pg from common to purecalc #9512

merged 2 commits into from
Sep 23, 2024

Conversation

@kardymonds
Copy link
Collaborator

@kardymonds kardymonds commented Sep 19, 2024

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

Refactoring for #5544

@kardymonds kardymonds requested a review from a team as a code owner September 19, 2024 13:24
@github-actions
Copy link

github-actions bot commented Sep 19, 2024 •
edited
Loading

⚪ 2024-09-19 13:24:50 UTC Pre-commit check linux-x86_64-release-clang14 for f9c1a0c has started.
⚪ 2024-09-19 13:25:33 UTC Artifacts will be uploaded here
⚪ 2024-09-19 13:28:30 UTC ya make is running...
🟢 2024-09-19 13:29:55 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Sep 19, 2024 •
edited
Loading

⚪ 2024-09-19 13:25:26 UTC Pre-commit check linux-x86_64-release-asan for f9c1a0c has started.
⚪ 2024-09-19 13:25:36 UTC Artifacts will be uploaded here
⚪ 2024-09-19 13:28:03 UTC ya make is running...
🟢 2024-09-19 13:31:09 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
160 160 0 0 0 0

🟢 2024-09-19 13:31:15 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Sep 19, 2024 •
edited
Loading

⚪ 2024-09-19 13:25:40 UTC Pre-commit check linux-x86_64-relwithdebinfo for f9c1a0c has started.
⚪ 2024-09-19 13:26:08 UTC Artifacts will be uploaded here
⚪ 2024-09-19 13:28:35 UTC ya make is running...
🟢 2024-09-19 13:30:42 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
180 180 0 0 0 0

🟢 2024-09-19 13:30:49 UTC Build successful.

dorooleg
dorooleg previously approved these changes Sep 19, 2024
View reviewed changes
uzhastik
uzhastik previously approved these changes Sep 19, 2024
View reviewed changes
rvu1024
rvu1024 reviewed Sep 19, 2024
View reviewed changes
ydb/library/yql/public/purecalc/no_llvm/ya.make Outdated
ydb/library/yql/minikql/computation/no_llvm
ydb/library/yql/minikql/invoke_builtins/no_llvm
ydb/library/yql/minikql/comp_nodes/no_llvm
ydb/library/yql/sql/pg
Copy link
Member

@rvu1024 rvu1024 Sep 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Это двигать не нужно

@rvu1024
Copy link
Member

rvu1024 commented Sep 19, 2024

Нужен чек в аркадии

@kardymonds kardymonds dismissed stale reviews from uzhastik and dorooleg via e920787 September 20, 2024 09:35
@github-actions
Copy link

github-actions bot commented Sep 20, 2024 •
edited
Loading

⚪ 2024-09-20 09:36:56 UTC Pre-commit check linux-x86_64-relwithdebinfo for 620acc2 has started.
⚪ 2024-09-20 09:37:32 UTC Artifacts will be uploaded here
⚪ 2024-09-20 09:40:34 UTC ya make is running...
🟢 2024-09-20 09:42:39 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
180 180 0 0 0 0

🟢 2024-09-20 09:42:46 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Sep 20, 2024 •
edited
Loading

⚪ 2024-09-20 09:38:48 UTC Pre-commit check linux-x86_64-release-asan for 620acc2 has started.
⚪ 2024-09-20 09:38:59 UTC Artifacts will be uploaded here
⚪ 2024-09-20 09:41:25 UTC ya make is running...
🟢 2024-09-20 09:44:41 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
160 160 0 0 0 0

🟢 2024-09-20 09:44:48 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Sep 20, 2024 •
edited
Loading

⚪ 2024-09-20 09:38:51 UTC Pre-commit check linux-x86_64-release-clang14 for 620acc2 has started.
⚪ 2024-09-20 09:39:01 UTC Artifacts will be uploaded here
⚪ 2024-09-20 09:41:25 UTC ya make is running...
🟢 2024-09-20 09:42:54 UTC Build successful.

@kardymonds kardymonds enabled auto-merge (squash) September 20, 2024 13:40
@aakulaga-ydb aakulaga-ydb self-requested a review September 23, 2024 07:27
@kardymonds kardymonds merged commit adb490f into ydb-platform:main Sep 23, 2024
This was referenced Sep 23, 2024
Merged
Closed
@niksaveliev niksaveliev mentioned this pull request Sep 24, 2024
Merged
This was referenced Sep 25, 2024
Merged
Merged
kardymonds added a commit to kardymonds/ydb that referenced this pull request Sep 30, 2024
@kardymonds
YQ-3322 Move pg from common to purecalc (ydb-platform#9512)
7561efc
@GrigoriyPA GrigoriyPA mentioned this pull request Oct 1, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Oct 3, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Oct 8, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Oct 10, 2024
Merged
This was referenced Oct 21, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rvu1024 rvu1024 rvu1024 left review comments

@uzhastik uzhastik uzhastik approved these changes

@dorooleg dorooleg dorooleg left review comments

+1 more reviewer

@aakulaga-ydb aakulaga-ydb aakulaga-ydb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kardymonds @rvu1024 @dorooleg @uzhastik @aakulaga-ydb