Skip to content

Forbid scheme ops on backup table #9431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

CyberROFL
Copy link
Member

@CyberROFL CyberROFL commented Sep 18, 2024

Changelog entry

Scheme operations (e.g. AlterTable) are now forbidden on backup tables.

Changelog category

  • Bugfix

Additional information

...

@CyberROFL CyberROFL requested review from snaury and ijon September 18, 2024 11:20
@CyberROFL CyberROFL self-assigned this Sep 18, 2024
Copy link

github-actions bot commented Sep 18, 2024

2024-09-18 11:21:01 UTC Pre-commit check linux-x86_64-release-asan for 82e5d6a has started.
2024-09-18 11:21:11 UTC Artifacts will be uploaded here
2024-09-18 11:23:57 UTC ya make is running...
🔴 2024-09-18 13:11:49 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10427 10230 0 35 48 114

🟢 2024-09-18 13:12:43 UTC Build successful.
🟢 2024-09-18 13:13:19 UTC ydbd size 5.6 GiB changed* by -18.6 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 853d462 merge: 82e5d6a diff diff %
ydbd size 6 053 415 848 Bytes 6 053 396 824 Bytes -18.6 KiB -0.000%
ydbd stripped size 1 514 440 304 Bytes 1 514 436 336 Bytes -3.9 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 18, 2024

2024-09-18 11:21:02 UTC Pre-commit check linux-x86_64-release-clang14 for 82e5d6a has started.
2024-09-18 11:21:11 UTC Artifacts will be uploaded here
2024-09-18 11:24:06 UTC ya make is running...
🟢 2024-09-18 11:31:18 UTC Build successful.

@github-actions github-actions bot added bugfix and removed bugfix labels Sep 18, 2024
@CyberROFL CyberROFL marked this pull request as ready for review September 18, 2024 11:21
Copy link

github-actions bot commented Sep 18, 2024

2024-09-18 11:23:32 UTC Pre-commit check linux-x86_64-relwithdebinfo for 82e5d6a has started.
2024-09-18 11:23:42 UTC Artifacts will be uploaded here
2024-09-18 11:26:44 UTC ya make is running...
🟡 2024-09-18 12:29:14 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15061 13415 0 3 1603 40

2024-09-18 12:30:43 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-18 12:42:03 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
281 (only retried tests) 183 0 0 7 91

🟢 2024-09-18 12:42:11 UTC Build successful.
🟢 2024-09-18 12:42:50 UTC ydbd size 8.4 GiB changed* by -11.3 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 853d462 merge: 82e5d6a diff diff %
ydbd size 9 037 429 088 Bytes 9 037 417 480 Bytes -11.3 KiB -0.000%
ydbd stripped size 489 007 688 Bytes 489 006 792 Bytes -896 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@CyberROFL CyberROFL enabled auto-merge (squash) September 18, 2024 11:43
@CyberROFL CyberROFL disabled auto-merge September 18, 2024 12:47
@CyberROFL CyberROFL enabled auto-merge (squash) September 18, 2024 12:47
@CyberROFL CyberROFL merged commit cb655a4 into ydb-platform:main Sep 18, 2024
13 of 15 checks passed
@CyberROFL CyberROFL deleted the forbid-scheme-ops-on-backup-table branch September 18, 2024 13:15
CyberROFL added a commit to CyberROFL/ydb that referenced this pull request Sep 18, 2024
CyberROFL added a commit to CyberROFL/ydb that referenced this pull request Sep 18, 2024
@shnikd shnikd mentioned this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants