Skip to content

Support ydb dump for tables with serial types #9272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 23, 2024

Conversation

shnikd
Copy link
Collaborator

@shnikd shnikd commented Sep 16, 2024

No description provided.

Copy link

github-actions bot commented Sep 16, 2024

2024-09-16 05:46:15 UTC Pre-commit check linux-x86_64-release-clang14 for 5564d24 has started.
2024-09-16 05:46:24 UTC Artifacts will be uploaded here

Copy link

github-actions bot commented Sep 16, 2024

2024-09-16 05:46:48 UTC Pre-commit check linux-x86_64-release-asan for 5564d24 has started.
2024-09-16 05:46:59 UTC Artifacts will be uploaded here

Copy link

github-actions bot commented Sep 16, 2024

2024-09-16 05:48:20 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5564d24 has started.
2024-09-16 05:48:30 UTC Artifacts will be uploaded here

Copy link

github-actions bot commented Sep 17, 2024

2024-09-17 16:57:19 UTC Pre-commit check linux-x86_64-release-asan for 8062bab has started.
2024-09-17 16:57:30 UTC Artifacts will be uploaded here
2024-09-17 16:59:53 UTC Check cancelled

Copy link

github-actions bot commented Sep 17, 2024

2024-09-17 16:58:43 UTC Pre-commit check linux-x86_64-release-clang14 for 8062bab has started.
2024-09-17 16:59:29 UTC Artifacts will be uploaded here
2024-09-17 16:59:52 UTC Check cancelled

Copy link

github-actions bot commented Sep 17, 2024

2024-09-17 17:01:37 UTC Pre-commit check linux-x86_64-release-clang14 for 60877e3 has started.
2024-09-17 17:01:41 UTC Artifacts will be uploaded here
2024-09-17 17:05:06 UTC ya make is running...
🟢 2024-09-17 17:56:29 UTC Build successful.

Copy link

github-actions bot commented Sep 17, 2024

2024-09-17 17:03:23 UTC Pre-commit check linux-x86_64-release-asan for 60877e3 has started.
2024-09-17 17:03:32 UTC Artifacts will be uploaded here
2024-09-17 17:06:55 UTC ya make is running...
🔴 2024-09-17 19:34:38 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17233 17021 0 54 51 107

🟢 2024-09-17 19:36:37 UTC Build successful.
🟢 2024-09-17 19:39:21 UTC ydbd size 5.6 GiB changed* by +78.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 3a4de79 merge: 60877e3 diff diff %
ydbd size 6 048 555 168 Bytes 6 048 635 264 Bytes +78.2 KiB +0.001%
ydbd stripped size 1 513 394 768 Bytes 1 513 415 056 Bytes +19.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 17, 2024

2024-09-17 17:04:45 UTC Pre-commit check linux-x86_64-relwithdebinfo for 60877e3 has started.
2024-09-17 17:04:57 UTC Artifacts will be uploaded here
2024-09-17 17:08:21 UTC ya make is running...
🟡 2024-09-17 19:00:27 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
79682 65608 0 5 14035 34

2024-09-17 19:08:17 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-17 19:19:49 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
282 (only retried tests) 185 0 0 8 89

🟢 2024-09-17 19:19:57 UTC Build successful.
🟡 2024-09-17 19:20:37 UTC ydbd size 8.4 GiB changed* by +110.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 7873f89 merge: 60877e3 diff diff %
ydbd size 9 034 329 384 Bytes 9 034 442 632 Bytes +110.6 KiB +0.001%
ydbd stripped size 488 824 072 Bytes 488 826 312 Bytes +2.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@pixcc pixcc self-requested a review September 19, 2024 15:41
Copy link

github-actions bot commented Sep 20, 2024

2024-09-20 12:48:43 UTC Pre-commit check linux-x86_64-release-clang14 for 5a1be51 has started.
2024-09-20 12:49:11 UTC Artifacts will be uploaded here
2024-09-20 12:52:32 UTC ya make is running...
🟢 2024-09-20 13:43:44 UTC Build successful.

Copy link

github-actions bot commented Sep 20, 2024

2024-09-20 12:51:21 UTC Pre-commit check linux-x86_64-release-asan for 5a1be51 has started.
2024-09-20 12:51:39 UTC Artifacts will be uploaded here
2024-09-20 12:55:37 UTC ya make is running...
🔴 2024-09-20 15:17:28 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17279 17079 0 32 58 110

🟢 2024-09-20 15:18:59 UTC Build successful.
🟡 2024-09-20 15:19:35 UTC ydbd size 5.6 GiB changed* by +1003.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 008aaab merge: 5a1be51 diff diff %
ydbd size 6 061 131 744 Bytes 6 062 158 912 Bytes +1003.1 KiB +0.017%
ydbd stripped size 1 516 200 496 Bytes 1 516 493 232 Bytes +285.9 KiB +0.019%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 20, 2024

2024-09-20 12:51:54 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5a1be51 has started.
2024-09-20 12:52:44 UTC Artifacts will be uploaded here
2024-09-20 12:56:27 UTC ya make is running...
🟡 2024-09-20 14:48:11 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
79755 65805 0 9 13829 112

2024-09-20 14:56:08 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-20 15:07:23 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
138 (only retried tests) 38 0 0 0 100

🟢 2024-09-20 15:07:32 UTC Build successful.
🟡 2024-09-20 15:08:17 UTC ydbd size 8.4 GiB changed* by +110.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 9143df5 merge: 5a1be51 diff diff %
ydbd size 9 043 587 480 Bytes 9 043 700 728 Bytes +110.6 KiB +0.001%
ydbd stripped size 489 392 776 Bytes 489 395 016 Bytes +2.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@@ -779,6 +779,8 @@ message DescribeTableRequest {
bool include_table_stats = 6;
// Includes partition statistics (required include_table_statistics)
bool include_partition_stats = 7;
// Includes set_val settings for sequences
bool include_set_val = 8;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Может include_sequence_positions?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SetVal уже используется в SequenceDescription

spuchin
spuchin previously approved these changes Sep 22, 2024
Copy link

github-actions bot commented Sep 23, 2024

2024-09-23 02:44:35 UTC Pre-commit check linux-x86_64-release-clang14 for 15c0cff has started.
2024-09-23 02:44:45 UTC Artifacts will be uploaded here
2024-09-23 02:48:08 UTC ya make is running...
🟢 2024-09-23 03:37:22 UTC Build successful.

Copy link

github-actions bot commented Sep 23, 2024

2024-09-23 02:44:38 UTC Pre-commit check linux-x86_64-relwithdebinfo for 15c0cff has started.
2024-09-23 02:44:48 UTC Artifacts will be uploaded here
2024-09-23 02:48:06 UTC ya make is running...
🟡 2024-09-23 04:35:08 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
79754 65670 0 6 14042 36

2024-09-23 04:42:39 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-23 04:54:02 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
280 (only retried tests) 180 0 0 7 93

🟢 2024-09-23 04:54:09 UTC Build successful.
🟡 2024-09-23 04:54:52 UTC ydbd size 8.4 GiB changed* by +114.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: b2b16e8 merge: 15c0cff diff diff %
ydbd size 9 045 166 848 Bytes 9 045 284 176 Bytes +114.6 KiB +0.001%
ydbd stripped size 489 475 496 Bytes 489 481 832 Bytes +6.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 23, 2024

2024-09-23 02:47:23 UTC Pre-commit check linux-x86_64-release-asan for 15c0cff has started.
2024-09-23 02:47:33 UTC Artifacts will be uploaded here
2024-09-23 02:50:58 UTC ya make is running...
🔴 2024-09-23 05:27:16 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17306 17028 0 90 72 116

🟢 2024-09-23 05:28:42 UTC Build successful.
🟢 2024-09-23 05:29:18 UTC ydbd size 5.6 GiB changed* by +82.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b2b16e8 merge: 15c0cff diff diff %
ydbd size 6 063 106 856 Bytes 6 063 191 040 Bytes +82.2 KiB +0.001%
ydbd stripped size 1 516 711 888 Bytes 1 516 736 272 Bytes +23.8 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@shnikd shnikd merged commit 7b2c0d2 into ydb-platform:main Sep 23, 2024
10 of 12 checks passed
shnikd added a commit to shnikd/ydb that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants