Skip to content

Reduce memory footprint for shards info #9207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

nikvas0
Copy link
Collaborator

@nikvas0 nikvas0 commented Sep 13, 2024

Changelog entry

Smaller memory footprint for shards info

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

Copy link

github-actions bot commented Sep 13, 2024

2024-09-13 10:11:31 UTC Pre-commit check linux-x86_64-release-asan for 9ffc167 has started.
2024-09-13 10:11:42 UTC Artifacts will be uploaded here
2024-09-13 10:14:38 UTC ya make is running...
🔴 2024-09-13 11:54:28 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10490 10162 0 29 267 32

🟢 2024-09-13 11:55:28 UTC Build successful.
🟡 2024-09-13 11:56:03 UTC ydbd size 5.6 GiB changed* by +102.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 7277322 merge: 9ffc167 diff diff %
ydbd size 6 051 861 984 Bytes 6 051 966 784 Bytes +102.3 KiB +0.002%
ydbd stripped size 1 514 636 208 Bytes 1 514 680 624 Bytes +43.4 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 13, 2024

2024-09-13 10:17:03 UTC Pre-commit check linux-x86_64-release-clang14 for 9ffc167 has started.
2024-09-13 10:17:24 UTC Artifacts will be uploaded here
2024-09-13 10:20:13 UTC ya make is running...
🟢 2024-09-13 10:26:53 UTC Build successful.

Copy link

github-actions bot commented Sep 13, 2024

2024-09-13 10:20:17 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9ffc167 has started.
2024-09-13 10:20:48 UTC Artifacts will be uploaded here
2024-09-13 10:24:03 UTC ya make is running...
🟡 2024-09-13 11:33:02 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39809 34085 0 15 5436 273

2024-09-13 11:36:49 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-13 11:47:01 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
289 (only retried tests) 190 0 5 7 87

2024-09-13 11:47:10 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-09-13 11:54:27 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
97 (only retried tests) 12 0 0 0 85

🟢 2024-09-13 11:54:34 UTC Build successful.
🟢 2024-09-13 11:55:21 UTC ydbd size 8.4 GiB changed* by +44.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f315577 merge: 9ffc167 diff diff %
ydbd size 9 042 108 856 Bytes 9 042 154 712 Bytes +44.8 KiB +0.001%
ydbd stripped size 488 864 360 Bytes 488 864 488 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nikvas0 nikvas0 marked this pull request as ready for review September 13, 2024 11:24
Copy link

github-actions bot commented Sep 13, 2024

2024-09-13 12:51:05 UTC Pre-commit check linux-x86_64-release-clang14 for c920a87 has started.
2024-09-13 12:51:14 UTC Artifacts will be uploaded here
2024-09-13 12:54:05 UTC ya make is running...
🟢 2024-09-13 13:32:56 UTC Build successful.

Copy link

github-actions bot commented Sep 13, 2024

2024-09-13 12:55:05 UTC Pre-commit check linux-x86_64-relwithdebinfo for c920a87 has started.
2024-09-13 12:55:53 UTC Artifacts will be uploaded here
2024-09-13 12:59:13 UTC ya make is running...
🟢 2024-09-13 14:22:39 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39821 34113 0 0 5435 273

🟢 2024-09-13 14:26:08 UTC Build successful.
🟢 2024-09-13 14:26:45 UTC ydbd size 8.4 GiB changed* by +13.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: acee834 merge: c920a87 diff diff %
ydbd size 9 043 659 032 Bytes 9 043 672 928 Bytes +13.6 KiB +0.000%
ydbd stripped size 488 880 936 Bytes 488 875 848 Bytes -5.0 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 13, 2024

2024-09-13 12:56:59 UTC Pre-commit check linux-x86_64-release-asan for c920a87 has started.
2024-09-13 12:59:50 UTC Artifacts will be uploaded here
2024-09-13 13:03:17 UTC ya make is running...
🔴 2024-09-13 15:14:11 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10512 10317 0 48 43 104

🟢 2024-09-13 15:15:11 UTC Build successful.
🟢 2024-09-13 15:15:45 UTC ydbd size 5.6 GiB changed* by -20.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: acee834 merge: c920a87 diff diff %
ydbd size 6 052 729 000 Bytes 6 052 708 128 Bytes -20.4 KiB -0.000%
ydbd stripped size 1 514 761 008 Bytes 1 514 747 024 Bytes -13.7 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@gridnevvvit gridnevvvit self-requested a review September 13, 2024 14:35
@nikvas0 nikvas0 enabled auto-merge (squash) September 13, 2024 14:35
@nikvas0 nikvas0 merged commit 1960e5f into ydb-platform:main Sep 13, 2024
10 of 12 checks passed
@nikvas0 nikvas0 changed the title Smaller memory footprint for shards info Reduce memory footprint for shards info Sep 13, 2024
nikvas0 added a commit to nikvas0/ydb that referenced this pull request Sep 16, 2024
nikvas0 added a commit to nikvas0/ydb that referenced this pull request Sep 17, 2024
@shnikd shnikd mentioned this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants