Skip to content

Add import ACL from S3 for tables #9181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 13, 2024
Merged

Add import ACL from S3 for tables #9181

merged 2 commits into from
Sep 13, 2024

Conversation

@pixcc
Copy link
Member

@pixcc pixcc commented Sep 12, 2024

Changelog category

  • Not for changelog (changelog entry is not required)

@pixcc pixcc requested a review from CyberROFL September 12, 2024 21:10
@github-actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

⚪ 2024-09-12 21:14:05 UTC Pre-commit check linux-x86_64-release-clang14 for 4c1e431 has started.
⚪ 2024-09-12 21:14:14 UTC Artifacts will be uploaded here
⚪ 2024-09-12 21:17:19 UTC ya make is running...
🟢 2024-09-12 21:33:40 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

⚪ 2024-09-12 21:14:10 UTC Pre-commit check linux-x86_64-release-asan for 4c1e431 has started.
⚪ 2024-09-12 21:14:20 UTC Artifacts will be uploaded here
⚪ 2024-09-12 21:17:28 UTC ya make is running...
🔴 2024-09-12 23:10:09 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17132 16780 0 29 269 54

🟢 2024-09-12 23:11:35 UTC Build successful.
🟡 2024-09-12 23:12:09 UTC ydbd size 5.6 GiB changed* by +122.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: e3b7f65 merge: 4c1e431 diff diff %
ydbd size 6 051 289 856 Bytes 6 051 415 576 Bytes +122.8 KiB +0.002%
ydbd stripped size 1 514 262 544 Bytes 1 514 290 704 Bytes +27.5 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

⚪ 2024-09-12 21:14:54 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4c1e431 has started.
⚪ 2024-09-12 21:15:04 UTC Artifacts will be uploaded here
⚪ 2024-09-12 21:18:08 UTC ya make is running...
🟡 2024-09-12 22:45:12 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
79538 65570 0 20 13853 95

⚪ 2024-09-12 22:52:48 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-12 23:03:27 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
162 (only retried tests) 75 0 1 1 85

⚪ 2024-09-12 23:03:35 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-09-12 23:12:32 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
91 (only retried tests) 5 0 1 0 85

🟢 2024-09-12 23:12:38 UTC Build successful.
🟡 2024-09-12 23:13:28 UTC ydbd size 8.4 GiB changed* by +148.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: e3b7f65 merge: 4c1e431 diff diff %
ydbd size 9 041 615 464 Bytes 9 041 766 992 Bytes +148.0 KiB +0.002%
ydbd stripped size 488 595 144 Bytes 488 602 792 Bytes +7.5 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@pixcc pixcc marked this pull request as ready for review September 12, 2024 21:42
@pixcc pixcc linked an issue Sep 12, 2024 that may be closed by this pull request
Import ACL from s3 for tables #9182
Closed
CyberROFL
CyberROFL previously approved these changes Sep 12, 2024
View reviewed changes
@pixcc pixcc requested a review from CyberROFL September 13, 2024 11:04
@github-actions
Copy link

github-actions bot commented Sep 13, 2024 •
edited
Loading

⚪ 2024-09-13 11:04:36 UTC Pre-commit check linux-x86_64-release-asan for 03f0d8f has started.
⚪ 2024-09-13 11:04:46 UTC Artifacts will be uploaded here
⚪ 2024-09-13 11:07:47 UTC ya make is running...
🔴 2024-09-13 13:05:48 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17133 16819 0 16 268 30

🟢 2024-09-13 13:07:14 UTC Build successful.
🟡 2024-09-13 13:08:36 UTC ydbd size 5.6 GiB changed* by +122.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: b0a5850 merge: 03f0d8f diff diff %
ydbd size 6 052 221 088 Bytes 6 052 346 848 Bytes +122.8 KiB +0.002%
ydbd stripped size 1 514 683 152 Bytes 1 514 711 248 Bytes +27.4 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 13, 2024 •
edited
Loading

⚪ 2024-09-13 11:04:46 UTC Pre-commit check linux-x86_64-relwithdebinfo for 03f0d8f has started.
⚪ 2024-09-13 11:04:57 UTC Artifacts will be uploaded here
⚪ 2024-09-13 11:08:04 UTC ya make is running...
🟡 2024-09-13 12:42:19 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
79555 65480 0 6 14037 32

⚪ 2024-09-13 12:50:28 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-13 13:00:45 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
276 (only retried tests) 182 0 0 8 86

🟢 2024-09-13 13:00:54 UTC Build successful.
🟡 2024-09-13 13:01:37 UTC ydbd size 8.4 GiB changed* by +145.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: b0a5850 merge: 03f0d8f diff diff %
ydbd size 9 043 008 192 Bytes 9 043 156 824 Bytes +145.1 KiB +0.002%
ydbd stripped size 488 863 720 Bytes 488 871 336 Bytes +7.4 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 13, 2024 •
edited
Loading

⚪ 2024-09-13 11:10:07 UTC Pre-commit check linux-x86_64-release-clang14 for 03f0d8f has started.
⚪ 2024-09-13 11:10:15 UTC Artifacts will be uploaded here
⚪ 2024-09-13 11:13:14 UTC ya make is running...
🟢 2024-09-13 11:39:04 UTC Build successful.

ijon
ijon reviewed Sep 13, 2024
View reviewed changes
ydb/core/tx/schemeshard/ut_helpers/ls_checks.h

TCheckFunc HasOwner(const TString& owner);
TCheckFunc HasRight(const TString& right);
TCheckFunc HasNotRight(const TString& right);
Copy link
Collaborator

@ijon ijon Sep 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HasNoRight?

@pixcc pixcc merged commit 3dce9fe into ydb-platform:main Sep 13, 2024
@StekPerepolnen StekPerepolnen mentioned this pull request Sep 17, 2024
Merged
This was referenced Sep 18, 2024
Merged
Merged
@shnikd shnikd mentioned this pull request Sep 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ijon ijon ijon approved these changes

@CyberROFL CyberROFL CyberROFL approved these changes

Assignees

No one assigned

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Import ACL from s3 for tables

3 participants

@pixcc @ijon @CyberROFL