Skip to content

fix for YQ-3287 #8970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Sep 19, 2024
Merged

fix for YQ-3287 #8970

merged 15 commits into from
Sep 19, 2024

Conversation

@evanevanevanevannnn
Copy link
Collaborator

@evanevanevanevannnn evanevanevanevannnn commented Sep 9, 2024

Changelog entry

fix for YQ-3287

Changelog category

  • Bugfix

@evanevanevanevannnn evanevanevanevannnn requested review from a team as code owners September 9, 2024 14:48
@github-actions github-actions bot added the bugfix label Sep 9, 2024
@github-actions
Copy link

github-actions bot commented Sep 9, 2024 •
edited
Loading

⚪ 2024-09-09 14:52:41 UTC Pre-commit check linux-x86_64-release-asan for d07aa64 has started.
⚪ 2024-09-09 14:55:44 UTC ya make is running...
🔴 2024-09-09 17:19:15 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11770 11533 0 123 69 45

🟢 2024-09-09 17:20:18 UTC Build successful.
🟢 2024-09-09 17:23:07 UTC ydbd size 5.6 GiB changed* by +3.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 7dd3f4d merge: d07aa64 diff diff %
ydbd size 6 036 440 800 Bytes 6 036 444 736 Bytes +3.8 KiB +0.000%
ydbd stripped size 1 511 075 440 Bytes 1 511 077 232 Bytes +1.8 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 9, 2024 •
edited
Loading

⚪ 2024-09-10 07:22:14 UTC Pre-commit check linux-x86_64-release-clang14 for d07aa64 has started.
⚪ 2024-09-10 07:25:28 UTC ya make is running...
🟢 2024-09-10 07:32:15 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Sep 9, 2024 •
edited
Loading

⚪ 2024-09-09 14:54:35 UTC Pre-commit check linux-x86_64-relwithdebinfo for d07aa64 has started.
⚪ 2024-09-09 14:58:40 UTC ya make is running...
🟡 2024-09-09 16:47:02 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
74008 60122 0 81 13776 29

⚪ 2024-09-09 16:54:42 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-09 17:01:57 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
121 (only retried tests) 21 0 77 0 23

⚪ 2024-09-09 17:02:06 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-09-09 17:09:20 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
109 (only retried tests) 10 0 77 0 22

🟢 2024-09-09 17:09:27 UTC Build successful.
🟢 2024-09-09 17:10:09 UTC ydbd size 8.4 GiB changed* by +3.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 7dd3f4d merge: d07aa64 diff diff %
ydbd size 9 023 382 160 Bytes 9 023 385 760 Bytes +3.5 KiB +0.000%
ydbd stripped size 487 698 792 Bytes 487 699 400 Bytes +608 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 10, 2024 •
edited
Loading

⚪ 2024-09-10 07:46:16 UTC Pre-commit check linux-x86_64-release-clang14 for 5293933 has started.
⚪ 2024-09-10 07:49:13 UTC ya make is running...
🟢 2024-09-10 07:55:52 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Sep 10, 2024 •
edited
Loading

⚪ 2024-09-10 07:46:42 UTC Pre-commit check linux-x86_64-release-asan for 5293933 has started.
⚪ 2024-09-10 07:49:44 UTC ya make is running...
🔴 2024-09-10 09:43:40 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11780 11563 0 65 115 37

🟢 2024-09-10 09:44:41 UTC Build successful.
🟢 2024-09-10 09:45:20 UTC ydbd size 5.6 GiB changed* by +3.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: dd142f6 merge: 5293933 diff diff %
ydbd size 6 036 912 800 Bytes 6 036 916 776 Bytes +3.9 KiB +0.000%
ydbd stripped size 1 511 084 976 Bytes 1 511 086 832 Bytes +1.8 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 10, 2024 •
edited
Loading

⚪ 2024-09-10 07:48:37 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5293933 has started.
⚪ 2024-09-10 07:51:30 UTC ya make is running...
🟡 2024-09-10 09:06:14 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
74010 60179 0 12 13792 27

⚪ 2024-09-10 09:14:00 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-10 09:25:35 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
63 (only retried tests) 42 0 0 1 20

🟢 2024-09-10 09:25:42 UTC Build successful.
🟢 2024-09-10 09:26:27 UTC ydbd size 8.4 GiB changed* by +5.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: dd142f6 merge: 5293933 diff diff %
ydbd size 9 024 182 440 Bytes 9 024 187 768 Bytes +5.2 KiB +0.000%
ydbd stripped size 487 703 400 Bytes 487 703 944 Bytes +544 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

uzhastik
uzhastik reviewed Sep 10, 2024
View reviewed changes
uzhastik
uzhastik reviewed Sep 10, 2024
View reviewed changes
@github-actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

⚪ 2024-09-11 08:34:36 UTC Pre-commit check linux-x86_64-release-clang14 for 4717cb0 has started.
⚪ 2024-09-11 08:34:45 UTC Artifacts will be uploaded here
⚪ 2024-09-11 08:37:36 UTC ya make is running...
🔴 2024-09-11 08:40:32 UTC Build failed, see the logs.

@github-actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

⚪ 2024-09-11 08:35:21 UTC Pre-commit check linux-x86_64-release-asan for 4717cb0 has started.
⚪ 2024-09-11 08:35:31 UTC Artifacts will be uploaded here
⚪ 2024-09-11 08:38:28 UTC ya make is running...
🔴 2024-09-11 08:41:29 UTC Build failed, see the logs.

@github-actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

⚪ 2024-09-11 08:35:34 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4717cb0 has started.
⚪ 2024-09-11 08:35:44 UTC Artifacts will be uploaded here
⚪ 2024-09-11 08:38:36 UTC ya make is running...
🔴 2024-09-11 08:42:40 UTC Build failed, see the logs.

@github-actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

⚪ 2024-09-11 08:56:04 UTC Pre-commit check linux-x86_64-release-asan for 81f968d has started.
⚪ 2024-09-11 08:56:15 UTC Artifacts will be uploaded here
⚪ 2024-09-11 08:59:09 UTC ya make is running...
🔴 2024-09-11 09:01:37 UTC Build failed, see the logs.

@github-actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

⚪ 2024-09-11 08:56:33 UTC Pre-commit check linux-x86_64-release-clang14 for 81f968d has started.
⚪ 2024-09-11 08:56:42 UTC Artifacts will be uploaded here
⚪ 2024-09-11 08:59:36 UTC ya make is running...
🔴 2024-09-11 09:04:01 UTC Build failed, see the logs.

@github-actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

⚪ 2024-09-11 08:56:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for 81f968d has started.
⚪ 2024-09-11 08:57:01 UTC Artifacts will be uploaded here
⚪ 2024-09-11 08:59:56 UTC ya make is running...
🔴 2024-09-11 09:04:10 UTC Build failed, see the logs.

@github-actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

⚪ 2024-09-11 09:27:46 UTC Pre-commit check linux-x86_64-release-asan for 7914f91 has started.
⚪ 2024-09-11 09:27:55 UTC Artifacts will be uploaded here
⚪ 2024-09-11 09:30:47 UTC ya make is running...
🔴 2024-09-11 11:20:52 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16900 16697 0 41 57 105

🟢 2024-09-11 11:22:24 UTC Build successful.
🟢 2024-09-11 11:22:57 UTC ydbd size 5.6 GiB changed* by +32.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a5fdd83 merge: 7914f91 diff diff %
ydbd size 6 040 636 632 Bytes 6 040 670 128 Bytes +32.7 KiB +0.001%
ydbd stripped size 1 511 598 480 Bytes 1 511 601 424 Bytes +2.9 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

⚪ 2024-09-11 09:28:26 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7914f91 has started.
⚪ 2024-09-11 09:28:36 UTC Artifacts will be uploaded here
⚪ 2024-09-11 09:31:37 UTC ya make is running...
🟡 2024-09-11 10:51:53 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
79178 65285 0 14 13786 93

⚪ 2024-09-11 10:59:25 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-11 11:09:48 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
113 (only retried tests) 27 0 0 0 86

🟢 2024-09-11 11:09:55 UTC Build successful.
🟢 2024-09-11 11:10:34 UTC ydbd size 8.4 GiB changed* by +44.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a5fdd83 merge: 7914f91 diff diff %
ydbd size 9 028 931 696 Bytes 9 028 976 960 Bytes +44.2 KiB +0.001%
ydbd stripped size 487 830 024 Bytes 487 830 440 Bytes +416 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

⚪ 2024-09-11 09:28:33 UTC Pre-commit check linux-x86_64-release-clang14 for 7914f91 has started.
⚪ 2024-09-11 09:28:36 UTC Artifacts will be uploaded here
⚪ 2024-09-11 09:31:28 UTC ya make is running...
🟢 2024-09-11 09:40:04 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

⚪ 2024-09-11 12:10:25 UTC Pre-commit check linux-x86_64-release-clang14 for 2a9e7bc has started.
⚪ 2024-09-11 12:10:40 UTC Artifacts will be uploaded here
⚪ 2024-09-11 12:13:36 UTC ya make is running...
🟢 2024-09-11 12:20:43 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

⚪ 2024-09-11 12:10:48 UTC Pre-commit check linux-x86_64-release-asan for 2a9e7bc has started.
⚪ 2024-09-11 12:11:38 UTC Artifacts will be uploaded here
⚪ 2024-09-11 12:15:11 UTC ya make is running...
🔴 2024-09-11 14:04:46 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16901 16686 0 55 57 103

🟢 2024-09-11 14:06:11 UTC Build successful.
🟢 2024-09-11 14:06:47 UTC ydbd size 5.6 GiB changed* by +33.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f6d081d merge: 2a9e7bc diff diff %
ydbd size 6 040 865 736 Bytes 6 040 899 800 Bytes +33.3 KiB +0.001%
ydbd stripped size 1 511 651 216 Bytes 1 511 663 120 Bytes +11.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 19, 2024 •
edited
Loading

⚪ 2024-09-19 09:18:11 UTC Pre-commit check linux-x86_64-release-asan for 23993d7 has started.
⚪ 2024-09-19 09:18:21 UTC Artifacts will be uploaded here
⚪ 2024-09-19 09:21:22 UTC ya make is running...
⚫ 2024-09-19 09:36:37 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Sep 19, 2024 •
edited
Loading

⚪ 2024-09-19 09:20:24 UTC Pre-commit check linux-x86_64-release-clang14 for 23993d7 has started.
⚪ 2024-09-19 09:20:34 UTC Artifacts will be uploaded here
⚪ 2024-09-19 09:23:33 UTC ya make is running...
⚫ 2024-09-19 09:36:17 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Sep 19, 2024 •
edited
Loading

⚪ 2024-09-19 09:20:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for 23993d7 has started.
⚪ 2024-09-19 09:20:36 UTC Artifacts will be uploaded here
⚪ 2024-09-19 09:23:38 UTC ya make is running...
⚫ 2024-09-19 09:36:26 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Sep 19, 2024 •
edited
Loading

⚪ 2024-09-19 09:38:12 UTC Pre-commit check linux-x86_64-release-clang14 for 5c172b5 has started.
⚪ 2024-09-19 09:38:22 UTC Artifacts will be uploaded here
⚪ 2024-09-19 09:41:22 UTC ya make is running...
⚫ 2024-09-19 09:49:05 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Sep 19, 2024 •
edited
Loading

⚪ 2024-09-19 09:38:22 UTC Pre-commit check linux-x86_64-release-asan for 5c172b5 has started.
⚪ 2024-09-19 09:38:33 UTC Artifacts will be uploaded here
⚪ 2024-09-19 09:41:34 UTC ya make is running...
⚫ 2024-09-19 09:49:16 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Sep 19, 2024 •
edited
Loading

⚪ 2024-09-19 09:39:16 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5c172b5 has started.
⚪ 2024-09-19 09:39:27 UTC Artifacts will be uploaded here
⚪ 2024-09-19 09:42:25 UTC ya make is running...
⚫ 2024-09-19 09:49:22 UTC Check cancelled

@evanevanevanevannnn evanevanevanevannnn added the rebase-and-check Rebase PR with the current base branch and check label Sep 19, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Sep 19, 2024
@github-actions
Copy link

github-actions bot commented Sep 19, 2024 •
edited
Loading

⚪ 2024-09-19 09:58:12 UTC Pre-commit check linux-x86_64-release-asan for a69a693 has started.
⚪ 2024-09-19 09:58:24 UTC Artifacts will be uploaded here
⚪ 2024-09-19 10:01:23 UTC ya make is running...
⚫ 2024-09-19 10:08:51 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Sep 19, 2024 •
edited
Loading

⚪ 2024-09-19 09:58:15 UTC Pre-commit check linux-x86_64-relwithdebinfo for a69a693 has started.
⚪ 2024-09-19 09:58:19 UTC Artifacts will be uploaded here
⚪ 2024-09-19 10:01:27 UTC ya make is running...
⚫ 2024-09-19 10:08:50 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Sep 19, 2024 •
edited
Loading

⚪ 2024-09-19 09:58:51 UTC Pre-commit check linux-x86_64-release-clang14 for a69a693 has started.
⚪ 2024-09-19 09:58:54 UTC Artifacts will be uploaded here
⚪ 2024-09-19 10:01:53 UTC ya make is running...
⚫ 2024-09-19 10:08:40 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Sep 19, 2024 •
edited
Loading

⚪ 2024-09-19 10:10:23 UTC Pre-commit check linux-x86_64-release-asan for 4822cb9 has started.
⚪ 2024-09-19 10:10:35 UTC Artifacts will be uploaded here
⚪ 2024-09-19 10:13:33 UTC ya make is running...
🔴 2024-09-19 11:59:17 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16996 16803 0 34 52 107

🟢 2024-09-19 12:00:43 UTC Build successful.
🟢 2024-09-19 12:01:17 UTC ydbd size 5.6 GiB changed* by +35.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 89c4688 merge: 4822cb9 diff diff %
ydbd size 6 058 334 504 Bytes 6 058 370 776 Bytes +35.4 KiB +0.001%
ydbd stripped size 1 515 537 392 Bytes 1 515 547 056 Bytes +9.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 19, 2024 •
edited
Loading

⚪ 2024-09-19 10:10:44 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4822cb9 has started.
⚪ 2024-09-19 10:10:55 UTC Artifacts will be uploaded here
⚪ 2024-09-19 10:13:52 UTC ya make is running...
🟡 2024-09-19 11:35:48 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
79442 65401 0 7 13931 103

⚪ 2024-09-19 11:43:19 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-19 11:54:33 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
237 (only retried tests) 146 0 0 0 91

🟢 2024-09-19 11:54:40 UTC Build successful.
🟢 2024-09-19 11:55:24 UTC ydbd size 8.4 GiB changed* by +73.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 89c4688 merge: 4822cb9 diff diff %
ydbd size 9 040 528 024 Bytes 9 040 603 528 Bytes +73.7 KiB +0.001%
ydbd stripped size 489 102 216 Bytes 489 110 536 Bytes +8.1 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 19, 2024 •
edited
Loading

⚪ 2024-09-19 10:11:43 UTC Pre-commit check linux-x86_64-release-clang14 for 4822cb9 has started.
⚪ 2024-09-19 10:12:10 UTC Artifacts will be uploaded here
⚪ 2024-09-19 10:15:14 UTC ya make is running...
🟢 2024-09-19 10:21:56 UTC Build successful.

@dorooleg
Copy link
Collaborator

dorooleg commented Sep 19, 2024

Договорились в отдельном ревью s3_read_actor исключения переделать на TCodeLineException

@evanevanevanevannnn evanevanevanevannnn enabled auto-merge (squash) September 19, 2024 14:47
@evanevanevanevannnn evanevanevanevannnn merged commit 6c61d9c into ydb-platform:main Sep 19, 2024
evanevanevanevannnn added a commit to evanevanevanevannnn/ydb that referenced this pull request Sep 20, 2024
@evanevanevanevannnn
fix for YQ-3287 (ydb-platform#8970)
f88c867
evanevanevanevannnn added a commit to evanevanevanevannnn/ydb that referenced this pull request Sep 23, 2024
@evanevanevanevannnn
fix for YQ-3287 (ydb-platform#8970)
f47adbe
@niksaveliev niksaveliev mentioned this pull request Sep 24, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Oct 3, 2024
Merged
@evanevanevanevannnn evanevanevanevannnn deleted the YQ_3287_fix branch October 7, 2024 10:00
@niksaveliev niksaveliev mentioned this pull request Oct 10, 2024
Merged
This was referenced Oct 21, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uzhastik uzhastik uzhastik left review comments

@dorooleg dorooleg dorooleg approved these changes

@rvu1024 rvu1024 rvu1024 approved these changes

Assignees

No one assigned

Labels

bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@evanevanevanevannnn @dorooleg @uzhastik @rvu1024