Skip to content

Conversation

@nepal
Copy link
Collaborator

@nepal nepal commented Sep 7, 2024

Changelog entry

  • Do not try to call IsComplete() on Arguments

Changelog category

  • Bugfix
  • Not for changelog (changelog entry is not required)

Additional information

...

@nepal nepal requested a review from a team as a code owner September 7, 2024 20:12
@github-actions github-actions bot added the bugfix label Sep 7, 2024
@nepal nepal added area/yql YQL query language issues and removed bugfix labels Sep 7, 2024
@github-actions
Copy link

github-actions bot commented Sep 7, 2024

2024-09-07 20:15:41 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8090c4d has started.
2024-09-07 20:18:34 UTC ya make is running...
🟡 2024-09-07 21:35:41 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
73164 59368 0 6 13767 23

2024-09-07 21:42:27 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-07 21:52:24 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39 (only retried tests) 21 0 0 0 18

🟢 2024-09-07 21:52:30 UTC Build successful.
🟢 2024-09-07 21:53:07 UTC ydbd size 8.4 GiB changed* by +560 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: e9c2717 merge: 8090c4d diff diff %
ydbd size 9 014 339 448 Bytes 9 014 340 008 Bytes +560 Bytes +0.000%
ydbd stripped size 487 349 096 Bytes 487 349 224 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 7, 2024

2024-09-07 20:15:44 UTC Pre-commit check linux-x86_64-release-asan for 8090c4d has started.
2024-09-07 20:18:46 UTC ya make is running...
🔴 2024-09-07 21:51:31 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10934 10846 0 22 36 30

🟢 2024-09-07 21:52:27 UTC Build successful.
🟢 2024-09-07 21:52:58 UTC ydbd size 5.6 GiB changed* by +128 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: e9c2717 merge: 8090c4d diff diff %
ydbd size 6 030 031 384 Bytes 6 030 031 512 Bytes +128 Bytes +0.000%
ydbd stripped size 1 509 853 904 Bytes 1 509 853 840 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 7, 2024

2024-09-07 20:17:54 UTC Pre-commit check linux-x86_64-release-clang14 for 8090c4d has started.
2024-09-07 20:20:43 UTC ya make is running...
🟢 2024-09-07 20:26:47 UTC Build successful.

@nepal nepal merged commit fd7dfdf into ydb-platform:main Sep 7, 2024
@nepal nepal deleted the yql-19005-no-iscomplete-on-arguments branch September 7, 2024 21:58
@shnikd shnikd mentioned this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/yql YQL query language issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants