Skip to content

Merge stream-nb-24-3. Reduce huge amount of PDisk's chunks info printed into log #8876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Merge stream-nb-24-3. Reduce huge amount of PDisk's chunks info printed into log #8876

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 25 additions & 7 deletions ydb/core/blobstorage/pdisk/blobstorage_pdisk_impl_log.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,6 +466,28 @@ bool TPDisk::ProcessChunk0(const NPDisk::TEvReadLogResult &readLogResult, TStrin
return true;
}

static void PrintCondensedChunksList(TStringStream& str, const std::vector<ui32>& chunks) {
str << " [";
bool first = true;
std::optional<TChunkIdx> begin;
for (size_t i = 0; i < chunks.size(); ++i) {
if (!begin) {
begin = chunks[i];
}
if (i + 1 < chunks.size() && chunks[i] + 1 == chunks[i + 1]) {
continue;
}
str << (std::exchange(first, false) ? "" : " ");
if (*begin == chunks[i]) {
str << chunks[i];
} else {
str << *begin << "-" << chunks[i];
}
begin.reset();
}
str << "];";
}

void TPDisk::PrintChunksDebugInfo() {
auto print = [&] () {
std::map<TOwner, std::vector<ui32>> ownerToChunks;
Expand All @@ -479,17 +501,13 @@ void TPDisk::PrintChunksDebugInfo() {
str << "PDiskId# " << PDiskId << " PrintChunksDebugInfo; ";
for (auto& [owner, chunks] : ownerToChunks) {
std::sort(chunks.begin(), chunks.end());
str << " Owner# " << owner << " [";
bool first = true;
for (auto idx : chunks) {
str << (std::exchange(first, false) ? "" : " ") << idx;
}
str << "];";
str << " Owner# " << owner;
PrintCondensedChunksList(str, chunks);
}
return str.Str();
};

LOG_INFO_S(*ActorSystem, NKikimrServices::BS_PDISK, print());
LOG_DEBUG_S(*ActorSystem, NKikimrServices::BS_PDISK, print());
}

TRcBuf TPDisk::ProcessReadSysLogResult(ui64 &outWritePosition, ui64 &outLsn,
Expand Down