Add EnableAlterSharding option #8707

fexolm · 2024-09-04T08:10:41Z

Changelog entry

...

Additional information

...

github-actions · 2024-09-04T08:13:10Z

⚪ 2024-09-04 08:13:09 UTC Pre-commit check linux-x86_64-release-asan for bc775ce has started.
⚪ 2024-09-04 08:16:11 UTC ya make is running...
⚫ 2024-09-04 10:04:03 UTC Check cancelled

github-actions · 2024-09-04T08:13:30Z

⚪ 2024-09-04 08:13:30 UTC Pre-commit check linux-x86_64-release-clang14 for bc775ce has started.
⚪ 2024-09-04 08:16:31 UTC ya make is running...
🟢 2024-09-04 08:54:54 UTC Build successful.

github-actions · 2024-09-04T08:13:43Z

⚪ 2024-09-04 08:13:43 UTC Pre-commit check linux-x86_64-relwithdebinfo for bc775ce has started.
⚪ 2024-09-04 08:16:48 UTC ya make is running...
🟡 2024-09-04 09:55:12 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
40761	35278	0	53	5402	28

⚪ 2024-09-04 09:58:45 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-04 10:03:37 UTC ydbd size 8.3 GiB changed* by +7.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `a29e93b`	merge: `bc775ce`	diff	diff %
ydbd size	8 921 525 608 Bytes	8 921 533 104 Bytes	+7.3 KiB	+0.000%
ydbd stripped size	481 970 056 Bytes	481 970 376 Bytes	+320 Bytes	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}
⚫ 2024-09-04 10:03:38 UTC Check cancelled

github-actions · 2024-09-04T10:05:36Z

⚪ 2024-09-04 10:05:36 UTC Pre-commit check linux-x86_64-release-clang14 for 5c8f67f has started.
⚪ 2024-09-04 10:08:41 UTC ya make is running...
🟢 2024-09-04 10:29:31 UTC Build successful.

github-actions · 2024-09-04T10:05:55Z

⚪ 2024-09-04 10:05:55 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5c8f67f has started.
⚪ 2024-09-04 10:08:58 UTC ya make is running...
⚫ 2024-09-04 10:41:17 UTC Check cancelled

github-actions · 2024-09-04T10:07:21Z

⚪ 2024-09-04 10:07:20 UTC Pre-commit check linux-x86_64-release-asan for 5c8f67f has started.
⚪ 2024-09-04 10:10:22 UTC ya make is running...
⚫ 2024-09-04 10:41:19 UTC Check cancelled

github-actions · 2024-09-04T10:42:37Z

⚪ 2024-09-04 10:42:36 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5c7a6cd has started.
⚪ 2024-09-04 10:46:51 UTC ya make is running...
⚫ 2024-09-04 11:09:03 UTC Check cancelled

github-actions · 2024-09-04T10:42:57Z

⚪ 2024-09-04 10:42:56 UTC Pre-commit check linux-x86_64-release-clang14 for 5c7a6cd has started.
⚪ 2024-09-04 10:46:02 UTC ya make is running...
🟢 2024-09-04 10:52:42 UTC Build successful.

github-actions · 2024-09-04T10:43:03Z

⚪ 2024-09-04 10:43:02 UTC Pre-commit check linux-x86_64-release-asan for 5c7a6cd has started.
⚪ 2024-09-04 10:46:18 UTC ya make is running...
⚫ 2024-09-04 11:08:50 UTC Check cancelled

ydb/core/protos/config.proto

github-actions · 2024-09-04T11:11:31Z

⚪ 2024-09-04 11:11:30 UTC Pre-commit check linux-x86_64-release-clang14 for c3860d2 has started.
⚫ 2024-09-04 11:12:43 UTC Check cancelled

github-actions · 2024-09-04T11:17:08Z

⚪ 2024-09-04 11:17:08 UTC Pre-commit check linux-x86_64-release-clang14 for dae9a7b has started.
⚪ 2024-09-04 11:20:15 UTC ya make is running...
🟢 2024-09-04 12:09:47 UTC Build successful.

github-actions · 2024-09-04T11:17:26Z

⚪ 2024-09-04 11:17:25 UTC Pre-commit check linux-x86_64-release-asan for dae9a7b has started.
⚪ 2024-09-04 11:21:37 UTC ya make is running...
🔴 2024-09-04 13:26:39 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
11507	11448	0	11	27	21

🟢 2024-09-04 13:27:42 UTC Build successful.
🟢 2024-09-04 13:28:15 UTC ydbd size 5.5 GiB changed* by +10.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `5f731ba`	merge: `dae9a7b`	diff	diff %
ydbd size	5 957 188 968 Bytes	5 957 199 288 Bytes	+10.1 KiB	+0.000%
ydbd stripped size	1 490 117 520 Bytes	1 490 118 672 Bytes	+1.1 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-09-04T11:19:09Z

⚪ 2024-09-04 11:19:09 UTC Pre-commit check linux-x86_64-relwithdebinfo for dae9a7b has started.
⚪ 2024-09-04 11:22:29 UTC ya make is running...
🟡 2024-09-04 13:05:54 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
40756	35325	0	5	5402	24

⚪ 2024-09-04 13:09:34 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-04 13:19:39 UTC Tests successful.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
37 (only retried tests)	23	0	0	0	14

🟢 2024-09-04 13:19:46 UTC Build successful.
🟢 2024-09-04 13:20:26 UTC ydbd size 8.3 GiB changed* by +12.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `5f731ba`	merge: `dae9a7b`	diff	diff %
ydbd size	8 921 692 312 Bytes	8 921 705 440 Bytes	+12.8 KiB	+0.000%
ydbd stripped size	481 980 744 Bytes	481 981 544 Bytes	+800 Bytes	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

ijon · 2024-09-04T14:56:43Z

ydb/core/tx/schemeshard/olap/operations/alter_table.cpp

@@ -265,6 +265,12 @@ class TAlterColumnTable: public TSubOperation {

        auto result = MakeHolder<TProposeResponse>(NKikimrScheme::StatusAccepted, ui64(OperationId.GetTxId()), ui64(ssId));

+        const bool isAlterSharding = Transaction.HasAlterColumnTable() && Transaction.GetAlterColumnTable().HasReshardColumnTable();
+        if (isAlterSharding && !AppData()->FeatureFlags.GetEnableAlterShardingInColumnShard()) {


Its ok to check flag like this: here and at that point in time.

There is a single caveat though: AppData() is a global immutable object, and EnableAlterShardingInColumnShards value would not be affected by changes made through dynamic config updates.

Conflicts: ydb/core/kqp/ut/olap/blobs_sharing_ut.cpp ydb/core/protos/feature_flags.proto

Conflicts: ydb/core/protos/feature_flags.proto

github-actions bot added the new-feature label Sep 4, 2024

fexolm force-pushed the fexolm/enable-alter-sharding-option branch from 6530a1c to 952b980 Compare September 4, 2024 08:11

fexolm force-pushed the fexolm/enable-alter-sharding-option branch from 952b980 to dd324cf Compare September 4, 2024 10:02

fexolm requested a review from zverevgeny September 4, 2024 10:03

fexolm marked this pull request as ready for review September 4, 2024 10:03

fexolm force-pushed the fexolm/enable-alter-sharding-option branch from dd324cf to 1e75457 Compare September 4, 2024 10:40

fexolm requested a review from ivanmorozov333 September 4, 2024 10:40

swalrus1 reviewed Sep 4, 2024

View reviewed changes

ydb/core/protos/config.proto Outdated Show resolved Hide resolved

fexolm force-pushed the fexolm/enable-alter-sharding-option branch from 1e75457 to 81d0c28 Compare September 4, 2024 11:08

fexolm force-pushed the fexolm/enable-alter-sharding-option branch from 81d0c28 to f6226c0 Compare September 4, 2024 11:12

Add EnableAlterSharding option

ad74003

fexolm force-pushed the fexolm/enable-alter-sharding-option branch from f6226c0 to ad74003 Compare September 4, 2024 11:13

ivanmorozov333 approved these changes Sep 4, 2024

View reviewed changes

ijon reviewed Sep 4, 2024

View reviewed changes

fexolm merged commit f9b4a7d into ydb-platform:main Sep 4, 2024
10 of 12 checks passed

fexolm deleted the fexolm/enable-alter-sharding-option branch September 4, 2024 15:25

GrigoriyPA mentioned this pull request Sep 5, 2024

Fixed unit test ManyColumnShards #8777

Merged

niksaveliev mentioned this pull request Sep 9, 2024

Fix CLI max partitions default #8944

Merged

zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 10, 2024

Add EnableAlterSharding option (ydb-platform#8707)

712a1d5

Conflicts: ydb/core/kqp/ut/olap/blobs_sharing_ut.cpp ydb/core/protos/feature_flags.proto

zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 11, 2024

Add EnableAlterSharding option (ydb-platform#8707)

3e8fe34

Conflicts: ydb/core/kqp/ut/olap/blobs_sharing_ut.cpp ydb/core/protos/feature_flags.proto

niksaveliev mentioned this pull request Sep 12, 2024

Fix reading without consumer from federation #9136

Merged

zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 13, 2024

Add EnableAlterSharding option (ydb-platform#8707)

730c204

Conflicts: ydb/core/protos/feature_flags.proto

zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 15, 2024

Add EnableAlterSharding option (ydb-platform#8707)

b8363e1

Conflicts: ydb/core/protos/feature_flags.proto

zverevgeny mentioned this pull request Sep 16, 2024

Integrate latest changes in CS into stable branch #9271

Closed

StekPerepolnen mentioned this pull request Sep 17, 2024

doc hc api images source #9376

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add EnableAlterSharding option #8707

Add EnableAlterSharding option #8707

fexolm commented Sep 4, 2024

github-actions bot commented Sep 4, 2024 •

edited

Loading

github-actions bot commented Sep 4, 2024 •

edited

Loading

github-actions bot commented Sep 4, 2024 •

edited

Loading

github-actions bot commented Sep 4, 2024 •

edited

Loading

github-actions bot commented Sep 4, 2024 •

edited

Loading

github-actions bot commented Sep 4, 2024 •

edited

Loading

github-actions bot commented Sep 4, 2024 •

edited

Loading

github-actions bot commented Sep 4, 2024 •

edited

Loading

github-actions bot commented Sep 4, 2024 •

edited

Loading

github-actions bot commented Sep 4, 2024 •

edited

Loading

github-actions bot commented Sep 4, 2024 •

edited

Loading

github-actions bot commented Sep 4, 2024 •

edited

Loading

github-actions bot commented Sep 4, 2024 •

edited

Loading

ijon Sep 4, 2024

Add EnableAlterSharding option #8707

Add EnableAlterSharding option #8707

Conversation

fexolm commented Sep 4, 2024

Changelog entry

Changelog category

Additional information

github-actions bot commented Sep 4, 2024 • edited Loading

github-actions bot commented Sep 4, 2024 • edited Loading

github-actions bot commented Sep 4, 2024 • edited Loading

github-actions bot commented Sep 4, 2024 • edited Loading

github-actions bot commented Sep 4, 2024 • edited Loading

github-actions bot commented Sep 4, 2024 • edited Loading

github-actions bot commented Sep 4, 2024 • edited Loading

github-actions bot commented Sep 4, 2024 • edited Loading

github-actions bot commented Sep 4, 2024 • edited Loading

github-actions bot commented Sep 4, 2024 • edited Loading

github-actions bot commented Sep 4, 2024 • edited Loading

github-actions bot commented Sep 4, 2024 • edited Loading

github-actions bot commented Sep 4, 2024 • edited Loading

ijon Sep 4, 2024

Choose a reason for hiding this comment

github-actions bot commented Sep 4, 2024 •

edited

Loading

github-actions bot commented Sep 4, 2024 •

edited

Loading

github-actions bot commented Sep 4, 2024 •

edited

Loading

github-actions bot commented Sep 4, 2024 •

edited

Loading

github-actions bot commented Sep 4, 2024 •

edited

Loading

github-actions bot commented Sep 4, 2024 •

edited

Loading

github-actions bot commented Sep 4, 2024 •

edited

Loading

github-actions bot commented Sep 4, 2024 •

edited

Loading

github-actions bot commented Sep 4, 2024 •

edited

Loading

github-actions bot commented Sep 4, 2024 •

edited

Loading

github-actions bot commented Sep 4, 2024 •

edited

Loading

github-actions bot commented Sep 4, 2024 •

edited

Loading

github-actions bot commented Sep 4, 2024 •

edited

Loading