another fix for feature flags #8690

adameat · 2024-09-03T15:38:31Z

Changelog entry

another fix for feature flags

Changelog category

Bugfix
Not for changelog (changelog entry is not required)

github-actions · 2024-09-03T15:39:53Z

⚪ 2024-09-03 15:39:53 UTC Pre-commit check linux-x86_64-release-asan for e41af25 has started.
⚪ 2024-09-03 15:42:49 UTC ya make is running...
🔴 2024-09-03 18:05:00 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9901	9782	0	44	41	34

🟢 2024-09-03 18:05:53 UTC Build successful.
🟢 2024-09-03 18:06:28 UTC ydbd size 5.5 GiB changed* by -44.6 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `908016b`	merge: `e41af25`	diff	diff %
ydbd size	5 955 071 760 Bytes	5 955 026 112 Bytes	-44.6 KiB	-0.001%
ydbd stripped size	1 489 560 048 Bytes	1 489 545 488 Bytes	-14.2 KiB	-0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-09-03T15:39:54Z

⚪ 2024-09-03 15:39:54 UTC Pre-commit check linux-x86_64-release-clang14 for e41af25 has started.
⚪ 2024-09-03 15:42:42 UTC ya make is running...
🟢 2024-09-03 16:26:09 UTC Build successful.

github-actions · 2024-09-03T15:42:16Z

⚪ 2024-09-03 15:42:15 UTC Pre-commit check linux-x86_64-relwithdebinfo for e41af25 has started.
⚪ 2024-09-03 15:45:15 UTC ya make is running...
🟡 2024-09-03 17:18:59 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14343	12922	0	16	1378	27

⚪ 2024-09-03 17:20:13 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-03 17:27:33 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
66 (only retried tests)	44	0	1	0	21

⚪ 2024-09-03 17:27:41 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-09-03 17:35:39 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
28 (only retried tests)	8	0	1	0	19

🟢 2024-09-03 17:35:46 UTC Build successful.
🟢 2024-09-03 17:36:27 UTC ydbd size 8.3 GiB changed* by -93.6 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `908016b`	merge: `e41af25`	diff	diff %
ydbd size	8 918 919 976 Bytes	8 918 824 112 Bytes	-93.6 KiB	-0.001%
ydbd stripped size	481 840 264 Bytes	481 834 792 Bytes	-5.3 KiB	-0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-09-03T19:14:19Z

⚪ 2024-09-03 19:14:18 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9ed6a54 has started.
⚪ 2024-09-03 19:18:12 UTC ya make is running...
🟡 2024-09-03 20:11:21 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14334	12940	0	6	1364	24

⚪ 2024-09-03 20:12:35 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-03 20:50:38 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
43 (only retried tests)	21	0	3	0	19

⚪ 2024-09-03 20:50:46 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-09-03 21:27:53 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
28 (only retried tests)	7	0	2	0	19

🟢 2024-09-03 21:28:01 UTC Build successful.
🟢 2024-09-03 21:28:37 UTC ydbd size 8.3 GiB changed* by -205.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `ce6be6c`	merge: `9ed6a54`	diff	diff %
ydbd size	8 919 056 760 Bytes	8 918 846 336 Bytes	-205.5 KiB	-0.002%
ydbd stripped size	481 836 392 Bytes	481 824 552 Bytes	-11.6 KiB	-0.002%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-09-03T19:15:06Z

⚪ 2024-09-03 19:15:06 UTC Pre-commit check linux-x86_64-release-clang14 for 9ed6a54 has started.
⚪ 2024-09-03 19:19:10 UTC ya make is running...
🟢 2024-09-03 19:34:44 UTC Build successful.

github-actions · 2024-09-03T19:15:28Z

⚪ 2024-09-03 19:15:28 UTC Pre-commit check linux-x86_64-release-asan for 9ed6a54 has started.
⚪ 2024-09-03 19:18:13 UTC ya make is running...
🔴 2024-09-03 20:50:57 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9885	9807	0	28	27	23

🟢 2024-09-03 20:51:50 UTC Build successful.
🟢 2024-09-03 20:52:20 UTC ydbd size 5.5 GiB changed* by -87.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `ce6be6c`	merge: `9ed6a54`	diff	diff %
ydbd size	5 955 123 544 Bytes	5 955 034 064 Bytes	-87.4 KiB	-0.002%
ydbd stripped size	1 489 565 744 Bytes	1 489 538 544 Bytes	-26.6 KiB	-0.002%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-09-04T05:33:14Z

⚪ 2024-09-04 05:33:13 UTC Pre-commit check linux-x86_64-release-clang14 for 1bb653b has started.

github-actions · 2024-09-04T05:33:23Z

⚪ 2024-09-04 05:33:22 UTC Pre-commit check linux-x86_64-release-asan for 1bb653b has started.

github-actions · 2024-09-04T05:33:34Z

⚪ 2024-09-04 05:33:34 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1bb653b has started.

github-actions · 2024-09-04T09:55:03Z

⚪ 2024-09-04 09:55:02 UTC Pre-commit check linux-x86_64-release-clang14 for bed823b has started.
⚪ 2024-09-04 09:57:48 UTC ya make is running...
🟢 2024-09-04 10:03:34 UTC Build successful.

github-actions · 2024-09-04T09:56:19Z

⚪ 2024-09-04 09:56:18 UTC Pre-commit check linux-x86_64-release-asan for bed823b has started.
⚪ 2024-09-04 09:59:02 UTC ya make is running...
🔴 2024-09-04 11:28:41 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9882	9813	0	23	23	23

🟢 2024-09-04 11:29:31 UTC Build successful.
🟢 2024-09-04 11:30:01 UTC ydbd size 5.5 GiB changed* by -83.7 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `53df48f`	merge: `bed823b`	diff	diff %
ydbd size	5 957 206 272 Bytes	5 957 120 576 Bytes	-83.7 KiB	-0.001%
ydbd stripped size	1 490 120 400 Bytes	1 490 090 000 Bytes	-29.7 KiB	-0.002%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-09-04T09:57:07Z

⚪ 2024-09-04 09:57:07 UTC Pre-commit check linux-x86_64-relwithdebinfo for bed823b has started.
⚪ 2024-09-04 10:00:01 UTC ya make is running...
🟡 2024-09-04 11:02:14 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14331	12908	0	41	1361	21

⚪ 2024-09-04 11:03:27 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-04 11:13:25 UTC Tests successful.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
70 (only retried tests)	55	0	0	0	15

🟢 2024-09-04 11:13:32 UTC Build successful.
🟢 2024-09-04 11:14:13 UTC ydbd size 8.3 GiB changed* by -196.9 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `53df48f`	merge: `bed823b`	diff	diff %
ydbd size	8 921 732 560 Bytes	8 921 530 928 Bytes	-196.9 KiB	-0.002%
ydbd stripped size	481 983 240 Bytes	481 972 104 Bytes	-10.9 KiB	-0.002%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

antonkovalenko

Nice! 100%

adameat requested a review from a team as a code owner September 3, 2024 15:38

adameat enabled auto-merge (squash) September 3, 2024 15:38

github-actions bot added the bugfix label Sep 3, 2024

adameat force-pushed the fix-feature-flags3 branch from e4a2449 to 2d350f0 Compare September 3, 2024 19:12

adameat force-pushed the fix-feature-flags3 branch from 2d350f0 to 581fe19 Compare September 4, 2024 05:31

alexvru previously approved these changes Sep 4, 2024

View reviewed changes

antonkovalenko previously approved these changes Sep 4, 2024

View reviewed changes

adameat dismissed stale reviews from antonkovalenko and alexvru via 5446d85 September 4, 2024 09:50

adameat force-pushed the fix-feature-flags3 branch from 581fe19 to 5446d85 Compare September 4, 2024 09:50

another fix for feature flags

905574e

adameat force-pushed the fix-feature-flags3 branch from 5446d85 to 905574e Compare September 4, 2024 09:53

antonkovalenko approved these changes Sep 4, 2024

View reviewed changes

adameat merged commit 376e237 into ydb-platform:main Sep 4, 2024

GrigoriyPA mentioned this pull request Sep 5, 2024

Fixed unit test ManyColumnShards #8777

Merged

This was referenced Sep 9, 2024

Fix CLI max partitions default #8944

Merged

Fix reading without consumer from federation #9136

Merged

StekPerepolnen mentioned this pull request Sep 17, 2024

doc hc api images source #9376

Merged

adameat added a commit to adameat/ydb that referenced this pull request Oct 1, 2024

another fix for feature flags (ydb-platform#8690)

0a92a9e

adameat added a commit to adameat/ydb that referenced this pull request Oct 4, 2024

another fix for feature flags (ydb-platform#8690)

9f94460

adameat deleted the fix-feature-flags3 branch November 14, 2024 09:52

another fix for feature flags #8690

another fix for feature flags #8690

Uh oh!

Conversation

adameat commented Sep 3, 2024

Changelog entry

Changelog category

Uh oh!

github-actions bot commented Sep 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 4, 2024

Uh oh!

github-actions bot commented Sep 4, 2024

Uh oh!

github-actions bot commented Sep 4, 2024

Uh oh!

github-actions bot commented Sep 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

antonkovalenko left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Sep 3, 2024 •

edited

Loading

github-actions bot commented Sep 3, 2024 •

edited

Loading

github-actions bot commented Sep 3, 2024 •

edited

Loading

github-actions bot commented Sep 3, 2024 •

edited

Loading

github-actions bot commented Sep 3, 2024 •

edited

Loading

github-actions bot commented Sep 3, 2024 •

edited

Loading

github-actions bot commented Sep 4, 2024 •

edited

Loading

github-actions bot commented Sep 4, 2024 •

edited

Loading

github-actions bot commented Sep 4, 2024 •

edited

Loading