-
Notifications
You must be signed in to change notification settings - Fork 734
Fix MakeBlocks usage in BlockMapJoinCore computation node #8686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix MakeBlocks usage in BlockMapJoinCore computation node #8686
Conversation
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
This patch fixes block output processing in case when not all data created via
MakeBlockshas been yielded to the computation node callee.Since we have no guarantee which kind of array data
IArrayBuilderproduces,TBlockState.Slicecreates the "minimal-common-size" chunks of theTBlockState.Dequesvectors, to be returned to the callee. Before the fix, anything left inTBlockState.Dequeswas flushed in scope ofFillArrayssubroutine with the consecutiveMakeBlockscall. As a result of the patch,HasBlocksmethod has been introduced inTBlockJoinState, to check whether anything is left inTBlockState.Deques. The further input processing is proceeded only, when all blocks inTBlockState.Dequeshave been returned.Changelog category