Skip to content

Conversation

@kungasc
Copy link
Contributor

@kungasc kungasc commented Sep 2, 2024

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@github-actions
Copy link

github-actions bot commented Sep 2, 2024

2024-09-02 09:51:51 UTC Pre-commit check linux-x86_64-release-clang14 for 77115f2 has started.
2024-09-02 09:54:39 UTC ya make is running...
🔴 2024-09-02 09:54:52 UTC Build failed. see the logs.

@github-actions
Copy link

github-actions bot commented Sep 2, 2024

2024-09-02 09:53:11 UTC Pre-commit check linux-x86_64-release-asan for 77115f2 has started.
2024-09-02 09:55:55 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Sep 2, 2024

2024-09-02 09:54:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for 77115f2 has started.
2024-09-02 09:56:07 UTC Check cancelled

@kungasc kungasc changed the title Introduce common cache interface Introduce a common cache interface Sep 2, 2024
@kungasc kungasc mentioned this pull request Sep 2, 2024
33 tasks
@kungasc kungasc self-assigned this Sep 2, 2024
@github-actions
Copy link

github-actions bot commented Sep 2, 2024

2024-09-02 10:07:36 UTC Pre-commit check linux-x86_64-release-clang14 for 081e8db has started.
2024-09-02 10:10:26 UTC ya make is running...
🟢 2024-09-02 10:20:19 UTC Build successful.


ui64 MemLimitBytes;

void CreateCache() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Сразу вынес, ибо потом будет вызываться при обновлении настроек

@github-actions
Copy link

github-actions bot commented Sep 2, 2024

2024-09-02 10:17:44 UTC Pre-commit check linux-x86_64-relwithdebinfo for 081e8db has started.
2024-09-02 10:22:02 UTC ya make is running...
🟡 2024-09-02 11:19:26 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15718 14322 0 12 1365 19

2024-09-02 11:20:50 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-02 11:31:05 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
37 (only retried tests) 21 0 1 0 15

2024-09-02 11:31:13 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-09-02 11:39:57 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
22 (only retried tests) 8 0 0 0 14

🟢 2024-09-02 11:40:04 UTC Build successful.
🟡 2024-09-02 11:40:45 UTC ydbd size 8.3 GiB changed* by +862.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 1af55df merge: 081e8db diff diff %
ydbd size 8 915 367 680 Bytes 8 916 250 600 Bytes +862.2 KiB +0.010%
ydbd stripped size 481 569 224 Bytes 481 598 664 Bytes +28.8 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 2, 2024

2024-09-02 10:22:33 UTC Pre-commit check linux-x86_64-release-asan for 081e8db has started.
2024-09-02 10:26:24 UTC ya make is running...
🔴 2024-09-02 12:06:30 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11302 11225 0 26 25 26

🟢 2024-09-02 12:07:29 UTC Build successful.
🟢 2024-09-02 12:08:02 UTC ydbd size 5.5 GiB changed* by +19.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 601d749 merge: 081e8db diff diff %
ydbd size 5 953 727 952 Bytes 5 953 747 440 Bytes +19.0 KiB +0.000%
ydbd stripped size 1 489 319 504 Bytes 1 489 322 352 Bytes +2.8 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@kungasc kungasc requested a review from snaury September 2, 2024 12:18
@kungasc kungasc changed the title Introduce a common cache interface Introduce a common Shared Cache cache interface Sep 2, 2024
Copy link
Member

@snaury snaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Я не очень понимаю смысл этого изменения (по идее в будущем кеши должны работать по немного другому принципу, особенно в частности многопоточного touch). Но если тебе удобнее сначала реализовать другие стратегии кеширования, сведя к старому апи, то окей.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants