-
Notifications
You must be signed in to change notification settings - Fork 735
Introduce a common Shared Cache cache interface #8590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
441c131 to
f788310
Compare
|
|
||
| ui64 MemLimitBytes; | ||
|
|
||
| void CreateCache() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Сразу вынес, ибо потом будет вызываться при обновлении настроек
|
⚪ ⚪
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
snaury
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Я не очень понимаю смысл этого изменения (по идее в будущем кеши должны работать по немного другому принципу, особенно в частности многопоточного touch). Но если тебе удобнее сначала реализовать другие стратегии кеширования, сведя к старому апи, то окей.
Changelog entry
...
Changelog category
Additional information
...