Skip to content

fix race on enqueue tx_commit in case long synchronization #8588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ivanmorozov333
Copy link
Collaborator

  • Improvement
  • Bugfix

Copy link

github-actions bot commented Sep 2, 2024

2024-09-02 09:38:47 UTC Pre-commit check linux-x86_64-release-clang14 for 85e9344 has started.
2024-09-02 09:41:24 UTC ya make is running...
🔴 2024-09-02 09:45:40 UTC Build failed. see the logs.

Copy link

github-actions bot commented Sep 2, 2024

2024-09-02 09:39:26 UTC Pre-commit check linux-x86_64-relwithdebinfo for 85e9344 has started.
2024-09-02 09:42:15 UTC ya make is running...
2024-09-02 09:48:16 UTC Check cancelled

Copy link

github-actions bot commented Sep 2, 2024

2024-09-02 09:46:27 UTC Pre-commit check linux-x86_64-release-asan for 85e9344 has started.
2024-09-02 09:48:14 UTC Check cancelled

Copy link

github-actions bot commented Sep 2, 2024

2024-09-02 09:55:58 UTC Pre-commit check linux-x86_64-release-clang14 for bd1fd51 has started.
2024-09-02 09:58:36 UTC ya make is running...
🟢 2024-09-02 10:05:05 UTC Build successful.

Copy link

github-actions bot commented Sep 2, 2024

2024-09-02 09:56:58 UTC Pre-commit check linux-x86_64-release-asan for bd1fd51 has started.
2024-09-02 09:59:36 UTC ya make is running...
2024-09-02 10:28:08 UTC Check cancelled

Copy link

github-actions bot commented Sep 2, 2024

2024-09-02 09:57:19 UTC Pre-commit check linux-x86_64-relwithdebinfo for bd1fd51 has started.
2024-09-02 10:00:06 UTC ya make is running...
2024-09-02 10:27:54 UTC Check cancelled

Copy link

github-actions bot commented Sep 2, 2024

2024-09-02 10:41:03 UTC Pre-commit check linux-x86_64-release-clang14 for 4830d43 has started.
2024-09-02 10:43:49 UTC ya make is running...
🟢 2024-09-02 10:50:54 UTC Build successful.

Copy link

github-actions bot commented Sep 2, 2024

2024-09-02 10:46:35 UTC Pre-commit check linux-x86_64-release-asan for 4830d43 has started.
2024-09-02 10:50:25 UTC ya make is running...
🔴 2024-09-02 12:25:15 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10023 9946 0 19 30 28

🟢 2024-09-02 12:26:09 UTC Build successful.
🟢 2024-09-02 12:26:40 UTC ydbd size 5.5 GiB changed* by +16.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 6313a44 merge: 4830d43 diff diff %
ydbd size 5 953 848 672 Bytes 5 953 865 416 Bytes +16.4 KiB +0.000%
ydbd stripped size 1 489 337 104 Bytes 1 489 339 920 Bytes +2.8 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 2, 2024

2024-09-02 11:04:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4830d43 has started.
2024-09-02 11:08:56 UTC ya make is running...
🟡 2024-09-02 12:09:31 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14260 12857 0 15 1369 19

2024-09-02 12:10:44 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-02 12:21:14 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
42 (only retried tests) 26 0 1 0 15

2024-09-02 12:21:21 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-09-02 12:29:25 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
21 (only retried tests) 8 0 0 0 13

🟢 2024-09-02 12:29:32 UTC Build successful.
🟢 2024-09-02 12:30:12 UTC ydbd size 8.3 GiB changed* by +18.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 6313a44 merge: 4830d43 diff diff %
ydbd size 8 916 393 416 Bytes 8 916 412 392 Bytes +18.5 KiB +0.000%
ydbd stripped size 481 603 016 Bytes 481 603 976 Bytes +960 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 marked this pull request as ready for review September 2, 2024 15:32
@ivanmorozov333 ivanmorozov333 merged commit 892228d into ydb-platform:main Sep 2, 2024
10 of 12 checks passed
@ivanmorozov333 ivanmorozov333 deleted the fix_race_on_tx_commit_enqueue branch September 2, 2024 15:32
KirillKurdyukov pushed a commit to KirillKurdyukov/ydb that referenced this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants