Skip to content

fix(kqp): check that src shardId is not zero in IsCrossShardChannel() #8438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ulya-sidorina
Copy link
Collaborator

No description provided.

@ulya-sidorina ulya-sidorina changed the title fix(kqp): always take snapshot for queries with stream lookup (#8267) fix(kqp): check that src shardId is not zero in IsCrossShardChannel() Aug 29, 2024
Copy link

github-actions bot commented Aug 29, 2024

2024-08-29 08:23:49 UTC Pre-commit check for d5fe2fc has started.
2024-08-29 08:23:52 UTC Build linux-x86_64-release-asan is running...
🟢 2024-08-29 09:23:57 UTC Build successful.
2024-08-29 09:25:41 UTC Tests are running...
🔴 2024-08-29 11:25:59 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9167 9061 0 14 62 30

Copy link

github-actions bot commented Aug 29, 2024

2024-08-29 08:23:56 UTC Pre-commit check for d5fe2fc has started.
2024-08-29 08:23:59 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-08-29 09:30:15 UTC Build successful.

Copy link

github-actions bot commented Aug 29, 2024

2024-08-29 08:24:01 UTC Pre-commit check for d5fe2fc has started.
2024-08-29 08:24:04 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-08-29 09:27:29 UTC Build successful.
2024-08-29 09:29:15 UTC Tests are running...
🔴 2024-08-29 10:56:09 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9339 9290 0 1 27 21

@ulya-sidorina ulya-sidorina marked this pull request as ready for review August 29, 2024 09:11
@ulya-sidorina ulya-sidorina requested a review from a team as a code owner August 29, 2024 09:11
@ulya-sidorina ulya-sidorina merged commit ddef8fd into ydb-platform:stable-24-2-7-hotfix Aug 29, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stream lookup always needs snapshot (for ISOLATION_LEVEL_SERIALIZABLE)
2 participants