Skip to content

fix streamlookup keys join on unmatched rows #8422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 30, 2024
Merged

fix streamlookup keys join on unmatched rows #8422

merged 4 commits into from
Aug 30, 2024

Conversation

@yumkam
Copy link
Collaborator

@yumkam yumkam commented Aug 28, 2024 •
edited
Loading 

SELECT s.id, db.id FROM yds.`in` AS s
  LEFT JOIN /*+ streamlookup() */ ydb.`db` as db
    ON s.id = db.id;

returned db.id equal to s.id on unmatched rows, it should've been NULL

Changelog entry

...

Changelog category

  • Bugfix
  • Not for changelog (changelog entry is not required)

Additional information

...

@yumkam yumkam requested a review from zverevgeny August 28, 2024 17:10
@github-actions
Copy link

github-actions bot commented Aug 28, 2024 •
edited
Loading

⚪ 2024-08-28 17:15:26 UTC Pre-commit check linux-x86_64-release-asan for d0f1a28 has started.
⚪ 2024-08-28 17:19:01 UTC ya make is running...
🔴 2024-08-28 18:55:17 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9837 9773 0 15 26 23

🟢 2024-08-28 18:56:11 UTC Build successful.
🟡 2024-08-28 18:56:42 UTC ydbd size 5.5 GiB changed* by +1.1 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 93d0e7f merge: d0f1a28 diff diff %
ydbd size 5 935 064 128 Bytes 5 936 224 376 Bytes +1.1 MiB +0.020%
ydbd stripped size 1 490 634 800 Bytes 1 490 929 232 Bytes +287.5 KiB +0.020%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 28, 2024 •
edited
Loading

⚪ 2024-08-28 17:16:05 UTC Pre-commit check linux-x86_64-relwithdebinfo for d0f1a28 has started.
⚪ 2024-08-28 17:18:46 UTC ya make is running...
🟡 2024-08-28 18:34:56 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38825 33449 0 3 5358 15

⚪ 2024-08-28 18:38:32 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-08-28 18:47:10 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
21 (only retried tests) 9 0 0 0 12

🟢 2024-08-28 18:47:18 UTC Build successful.
🟡 2024-08-28 18:48:01 UTC ydbd size 8.2 GiB changed* by +1.6 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 93d0e7f merge: d0f1a28 diff diff %
ydbd size 8 807 796 432 Bytes 8 809 524 272 Bytes +1.6 MiB +0.020%
ydbd stripped size 480 298 024 Bytes 480 388 360 Bytes +88.2 KiB +0.019%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 28, 2024 •
edited
Loading

⚪ 2024-08-28 17:16:10 UTC Pre-commit check linux-x86_64-release-clang14 for d0f1a28 has started.
⚪ 2024-08-28 17:18:59 UTC ya make is running...
🟢 2024-08-28 17:51:28 UTC Build successful.

yumkam added 3 commits August 29, 2024 11:09
@yumkam
fix streamlookup keys join on unmatch
9685c68 
SELECT s.id, db.id FROM yds.`in` AS s
  LEFT JOIN /*+ streamlookup() */ ydb.`db` as db
    ON s.id = db.id;
returned db.id equal to s.id on unmatched rows
@yumkam
comment-out debug prints
c265dce
@yumkam
add tests
c8c7418
@yumkam yumkam force-pushed the fix-streamlookup-2 branch from 32e0608 to c8c7418 Compare August 29, 2024 09:03
@yumkam yumkam marked this pull request as ready for review August 29, 2024 09:04
@yumkam yumkam requested review from a team as code owners August 29, 2024 09:04
@github-actions
Copy link

github-actions bot commented Aug 29, 2024 •
edited
Loading

⚪ 2024-08-29 09:05:05 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7e52520 has started.
⚪ 2024-08-29 09:07:52 UTC ya make is running...
🟡 2024-08-29 10:11:24 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38850 33450 0 8 5371 21

⚪ 2024-08-29 10:14:49 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-08-29 10:24:52 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
42 (only retried tests) 29 0 1 0 12

⚪ 2024-08-29 10:25:00 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-08-29 10:32:26 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18 (only retried tests) 5 0 1 0 12

🟢 2024-08-29 10:32:33 UTC Build successful.
🟢 2024-08-29 10:33:10 UTC ydbd size 8.2 GiB changed* by +1016 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 37b4d6c merge: 7e52520 diff diff %
ydbd size 8 810 199 888 Bytes 8 810 200 904 Bytes +1016 Bytes +0.000%
ydbd stripped size 480 426 888 Bytes 480 427 144 Bytes +256 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 29, 2024 •
edited
Loading

⚪ 2024-08-29 09:05:05 UTC Pre-commit check linux-x86_64-release-asan for 7e52520 has started.
⚪ 2024-08-29 09:07:54 UTC ya make is running...
🔴 2024-08-29 10:57:04 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9848 9743 0 21 49 35

🟢 2024-08-29 10:57:58 UTC Build successful.
🟢 2024-08-29 10:58:34 UTC ydbd size 5.5 GiB changed* by +848 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 37b4d6c merge: 7e52520 diff diff %
ydbd size 5 936 630 776 Bytes 5 936 631 624 Bytes +848 Bytes +0.000%
ydbd stripped size 1 491 036 880 Bytes 1 491 037 136 Bytes +256 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 29, 2024 •
edited
Loading

⚪ 2024-08-29 09:05:13 UTC Pre-commit check linux-x86_64-release-clang14 for 7e52520 has started.
⚪ 2024-08-29 09:08:08 UTC ya make is running...
🟢 2024-08-29 09:31:10 UTC Build successful.

@yumkam yumkam requested review from aakulaga-ydb and rvu1024 August 29, 2024 09:08
@github-actions github-actions bot added bugfix and removed bugfix labels Aug 29, 2024
@github-actions
Copy link

github-actions bot commented Aug 29, 2024 •
edited
Loading

⚪ 2024-08-29 11:36:23 UTC Pre-commit check linux-x86_64-release-clang14 for 8db98d0 has started.
⚪ 2024-08-29 11:39:21 UTC ya make is running...
🟢 2024-08-29 11:44:27 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Aug 29, 2024 •
edited
Loading

⚪ 2024-08-29 11:46:00 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8db98d0 has started.
⚪ 2024-08-29 11:49:57 UTC ya make is running...
🟡 2024-08-29 12:47:14 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38891 33502 0 4 5367 18

⚪ 2024-08-29 12:50:50 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-08-29 13:00:47 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
32 (only retried tests) 20 0 0 0 12

🟢 2024-08-29 13:00:55 UTC Build successful.
🟢 2024-08-29 13:01:30 UTC ydbd size 8.2 GiB changed* by +1.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: acc9844 merge: 8db98d0 diff diff %
ydbd size 8 818 406 688 Bytes 8 818 407 760 Bytes +1.0 KiB +0.000%
ydbd stripped size 480 777 416 Bytes 480 777 608 Bytes +192 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 29, 2024 •
edited
Loading

⚪ 2024-08-29 11:53:51 UTC Pre-commit check linux-x86_64-release-asan for 8db98d0 has started.
⚪ 2024-08-29 11:57:14 UTC ya make is running...
🔴 2024-08-29 13:40:24 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9895 9789 0 44 38 24

🟢 2024-08-29 13:41:20 UTC Build successful.
🟢 2024-08-29 13:41:56 UTC ydbd size 5.5 GiB changed* by +400 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: acc9844 merge: 8db98d0 diff diff %
ydbd size 5 942 610 472 Bytes 5 942 610 872 Bytes +400 Bytes +0.000%
ydbd stripped size 1 492 424 624 Bytes 1 492 424 688 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@yumkam yumkam requested a review from kardymonds August 30, 2024 13:36
@aakulaga-ydb aakulaga-ydb merged commit e923efd into ydb-platform:main Aug 30, 2024
yumkam added a commit to yumkam/ydb that referenced this pull request Aug 30, 2024
@yumkam
fix streamlookup keys join on unmatched rows (ydb-platform#8422)
39978bf 
(cherry picked from commit e923efd)
@siarheivesialou siarheivesialou mentioned this pull request Sep 4, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Sep 4, 2024
Merged
kardymonds pushed a commit that referenced this pull request Sep 4, 2024
@yumkam
Fix streamlookupjoin (backport #8422) (#8540)
12d1cd4
This was referenced Sep 5, 2024
Merged
Merged
This was referenced Sep 9, 2024
Merged
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Sep 17, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Oct 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zverevgeny zverevgeny Awaiting requested review from zverevgeny

@rvu1024 rvu1024 Awaiting requested review from rvu1024

@kardymonds kardymonds Awaiting requested review from kardymonds

1 more reviewer

@aakulaga-ydb aakulaga-ydb aakulaga-ydb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yumkam @aakulaga-ydb